Skip to content

Fix backwards-compatibility check for tests with +whole-archive - #100068

Merged
bors merged 1 commit into
rust-lang:masterfrom
dcsommer:master
Aug 4, 2022
Merged

Fix backwards-compatibility check for tests with +whole-archive#100068
bors merged 1 commit into
rust-lang:masterfrom
dcsommer:master

Conversation

@dcsommer

Copy link
Copy Markdown
Contributor

Fixes#100066

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 2, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 2, 2022
@dcsommer

Copy link
Copy Markdown
ContributorAuthor

r? @petrochenkov

@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 9cf556d has been approved by petrochenkov

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2022
@petrochenkov

Copy link
Copy Markdown
Contributor

Beta-nominating, the mistake was introduced in 1.61.

Also stable-nominating for the unlikely case of a point release, but this fix by itself doesn't deserve a point release.

@petrochenkovpetrochenkov added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Aug 3, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 3, 2022
Fix backwards-compatibility check for tests with `+whole-archive`
Fixesrust-lang#100066
This was referenced Aug 3, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 4, 2022
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#98877 (Set llvm configs when building lld)
- rust-lang#100068 (Fix backwards-compatibility check for tests with `+whole-archive`)
- rust-lang#100083 (rustdoc: use a more compact encoding for source-files.js)
- rust-lang#100102 (Fix typo)
- rust-lang#100104 (Remove more Clean trait implementations)
- rust-lang#100105 (Add regression test for rust-lang#90871)
- rust-lang#100107 (fix trailing whitespace in error message)
- rust-lang#100111 (Provide suggestion on missing `let` in binding statement)
- rust-lang#100119 (FilesTimes support does not build for ESP-IDF)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 5a5f499 into rust-lang:masterAug 4, 2022
@rustbotrustbot added this to the 1.64.0 milestone Aug 4, 2022
@apiraino

Copy link
Copy Markdown
Contributor

Beta backport accepted as per compiler team on Zulip.

Stable nomination (assumed a 1.62.x) is not possible.

@rustbot label beta-accepted -stable-nominated

@rustbotrustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed stable-nominated Nominated for backporting to the compiler in the stable channel. labels Aug 4, 2022
@Mark-SimulacrumMark-Simulacrum modified the milestones: 1.64.0, 1.63.0Aug 5, 2022
@Mark-SimulacrumMark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 5, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 5, 2022
…mulacrum
[beta] Rollup of beta backports
Includes the following PRs:
* rustc-docs: Be less specific about the representation of +bundle rust-lang#100074
* Fix backwards-compatibility check for tests with +whole-archive rust-lang#100068
* Revert write! and writeln! to late drop temporaries rust-lang#99689
* Upgrade indexmap and thorin-dwp to use hashbrown 0.12 rust-lang#99251
* rustdoc: avoid inlining modules with duplicate names rust-lang#99738
r? `@ghost`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustc --test ignores static:-whole-archive link modifiers

8 participants

@dcsommer@rust-highfive@petrochenkov@bors@apiraino@Mark-Simulacrum@jackh726@rustbot