Skip to content

Rollup of 5 pull requests - #100100

Merged
bors merged 14 commits into
rust-lang:masterfrom
Dylan-DPC:rollup-llcaaq8
Aug 3, 2022
Merged

Rollup of 5 pull requests#100100
bors merged 14 commits into
rust-lang:masterfrom
Dylan-DPC:rollup-llcaaq8

Conversation

@Dylan-DPC

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

ChrisDentonand others added 14 commits July 17, 2022 11:16
Co-authored-by: Jubilee <46493976+workingjubilee@users.noreply.github.com>
Rustdoc's current syntax is `-> vec`.
…s, r=thomcc
Remove synchronization from Windows `hashmap_random_keys`
Unfortunately using synchronization when generating hashmap keys can prevent it being used in `DllMain`.
~~Fixesrust-lang#99341~~
…=thomcc
do not claim that transmute is like memcpy
Saying transmute is like memcpy is not a well-formed statement, since memcpy is by-ref whereas transmute is by-val. The by-val nature of transmute inherently means that padding is lost along the way. (This is not specific to transmute, this is how all by-value operations work.) So adjust the docs to clarify this aspect.
Cc `@workingjubilee`
…s-w-same-name, r=camelid
rustdoc: avoid inlining modules with duplicate names
Fixesrust-lang#99734
Fix futex module imports on wasm+atomics
The futex modules were rearranged a bit in rust-lang#98707, which meant that wasm+atomics would no longer compile on nightly. I don’t believe any other targets were impacted by this.
…an-DPC
Replace `* -> vec` with `-> vec` in docs
Fixesrust-lang#100078.
Rustdoc's current syntax is `-> vec`.
@rustbotrustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 3, 2022
@Dylan-DPC

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit e92b241 has been approved by Dylan-DPC

It is now in the queue for this repository.

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 3, 2022
@bors

bors commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e92b241 with merge 7308c22...

@bors

bors commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 7308c22 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 3, 2022
@bors
bors merged commit 7308c22 into rust-lang:masterAug 3, 2022
@rustbotrustbot added this to the 1.64.0 milestone Aug 3, 2022
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#Perf Build Sha
#100079e3efd912a491972cf0620feb5001ad8e11438427
#99800d71e23bc21b2bbdee3221ec0722969e4ab6715be
#997383cc1b331240d80e88f1009b27879a8a25dea1d48
#996144feaa59659424288d2224014424c3b087c54f264
#9937183c8dcfffad21b5aef81a1fb75c739afad10de6c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (7308c22): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Dylan-DPC@bors@rust-timer@rustbot@ChrisDenton@RalfJung@notriddle@sandydoo@camelid