Skip to content

rustdoc: use collect() instead of repeatedly pushing - #100157

Merged
bors merged 2 commits into
masterfrom
notriddle/use-map-instead-of-repeated-push
Aug 5, 2022
Merged

rustdoc: use collect() instead of repeatedly pushing#100157
bors merged 2 commits into
masterfrom
notriddle/use-map-instead-of-repeated-push

Conversation

@notriddle

@notriddlenotriddle commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@rustbotrustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 5, 2022
@rust-highfive

rust-highfive commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2022
@notriddle
notriddleforce-pushed the notriddle/use-map-instead-of-repeated-push branch from f3ab115 to 70a6ae6CompareAugust 5, 2022 01:14
@Dylan-DPC

Dylan-DPC commented Aug 5, 2022

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 70a6ae6 has been approved by Dylan-DPC

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2022
@GuillaumeGomez

GuillaumeGomez commented Aug 5, 2022

Copy link
Copy Markdown
Member

Looks good to me, let's check the perf impact.

@bors try @rust-timer queue

@rust-timer

rust-timer commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors

bors commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 5, 2022
@GuillaumeGomez

GuillaumeGomez commented Aug 5, 2022

Copy link
Copy Markdown
Member

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 5, 2022
@GuillaumeGomez

GuillaumeGomez commented Aug 5, 2022

Copy link
Copy Markdown
Member

@bors try @rust-timer queue

@rust-timer

rust-timer commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors

bors commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 70a6ae6 with merge 9b51c0f5fce573601edbbc5c51282424c63719d9...

@bors

bors commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 9b51c0f5fce573601edbbc5c51282424c63719d9 (9b51c0f5fce573601edbbc5c51282424c63719d9)

@rust-timer

rust-timer commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

Queued 9b51c0f5fce573601edbbc5c51282424c63719d9 with parent cdfd675, future comparison URL.

@rust-timer

rust-timer commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (9b51c0f5fce573601edbbc5c51282424c63719d9): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1maxcount2
Regressions 😿
(primary)		N/AN/A0
Regressions 😿
(secondary)		N/AN/A0
Improvements 🎉
(primary)		N/AN/A0
Improvements 🎉
(secondary)		-2.5%-2.5%1
All 😿🎉 (primary)N/AN/A0

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1maxcount2
Regressions 😿
(primary)		N/AN/A0
Regressions 😿
(secondary)		2.7%2.7%1
Improvements 🎉
(primary)		N/AN/A0
Improvements 🎉
(secondary)		-3.7%-3.7%1
All 😿🎉 (primary)N/AN/A0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change↩↩2

  2. number of relevant changes↩↩2

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 5, 2022
@notriddle

notriddle commented Aug 5, 2022

Copy link
Copy Markdown
ContributorAuthor

@bors r=Dylan-DPC

@bors

bors commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 70a6ae6 has been approved by Dylan-DPC

It is now in the queue for this repository.

@borsbors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2022
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 5, 2022
@notriddle

notriddle commented Aug 5, 2022

Copy link
Copy Markdown
ContributorAuthor

@bors rollup

@Dylan-DPCDylan-DPC mentioned this pull request Aug 5, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 5, 2022
@bors
Auto merge ofrust-lang#100174- Dylan-DPC:rollup-wnskbk6, r=Dylan-DPC
affe0d3
Rollup of 6 pull requests
Successful merges:
- rust-lang#99835 (Suggest adding/removing `ref` for binding patterns)
- rust-lang#100155 (Use `node_type_opt` to skip over generics that were not expected)
- rust-lang#100157 (rustdoc: use `collect()` instead of repeatedly pushing)
- rust-lang#100158 (kmc-solid: Add a stub implementation of rust-lang#98246 (`File::set_times`))
- rust-lang#100166 (Remove more Clean trait implementations)
- rust-lang#100168 (Improve diagnostics for `const a: = expr;`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 97440b5 into masterAug 5, 2022
@rustbotrustbot added this to the 1.64.0 milestone Aug 5, 2022
@bors
bors deleted the notriddle/use-map-instead-of-repeated-push branch August 5, 2022 20:06
@ehussehuss modified the milestones: 1.64.0, 1.65.0Aug 31, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

8 participants

@notriddle@rust-highfive@Dylan-DPC@bors@GuillaumeGomez@rust-timer@ehuss@rustbot