Skip to content

Remove more Clean trait implementations - #100212

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:rm-clean-impls
Aug 9, 2022
Merged

Remove more Clean trait implementations#100212
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:rm-clean-impls

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Follow-up of #99638.

r? @notriddle

@GuillaumeGomezGuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 6, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2022
@Dylan-DPC

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 7, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit a238d12 has been approved by Dylan-DPC

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2022
@bors

bors commented Aug 7, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a238d12 with merge 93e4400df536bc38f35a24392762ef978e856d1a...

@bors

bors commented Aug 7, 2022

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 7, 2022
@Dylan-DPC

Copy link
Copy Markdown
Member

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2022
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

@camelid

Copy link
Copy Markdown
Member

@bors retry one arch timed out

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 9, 2022
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#100163 (Refactor: remove an unnecessary string search)
- rust-lang#100212 (Remove more Clean trait implementations)
- rust-lang#100238 (Further improve error message for E0081)
- rust-lang#100268 (Add regression test for rust-lang#79148)
- rust-lang#100294 (Update Duration::as_secs doc to point to as_secs_f64/32 for including fractional part)
- rust-lang#100303 (:arrow_up: rust-analyzer)
Failed merges:
- rust-lang#100281 (Remove more Clean trait implementations)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 65cc68b into rust-lang:masterAug 9, 2022
@rustbotrustbot added this to the 1.65.0 milestone Aug 9, 2022
@GuillaumeGomez
GuillaumeGomez deleted the rm-clean-impls branch August 9, 2022 11:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@GuillaumeGomez@Dylan-DPC@bors@rust-log-analyzer@camelid@notriddle@rust-highfive@rustbot