Uh oh!
There was an error while loading. Please reload this page.
remove an ineffective check in const_prop - #100239
Merged
Merged
Conversation
rustbot
commented
Aug 7, 2022
Collaborator
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rust-highfive
commented
Aug 7, 2022
Contributor
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
RalfJungforce-pushed
the
const-prop-uninit
branch
2 times, most recently
from
August 7, 2022 17:25
b3c5a09 to
48e0184Comparejackh726
commented
Aug 7, 2022
Member
Hmm, maybe r? @oli-obk would be a good choice here? Feel free to reassign. |
bors
commented
Aug 12, 2022
Collaborator
☔ The latest upstream changes (presumably #100456) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJungforce-pushed
the
const-prop-uninit
branch
from
August 20, 2022 04:11
48e0184 to
5c73f8eComparebors
commented
Aug 27, 2022
Collaborator
☔ The latest upstream changes (presumably #100043) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJungforce-pushed
the
const-prop-uninit
branch
from
August 27, 2022 12:53
5c73f8e to
aff9841CompareRalfJung
commented
Aug 27, 2022
MemberAuthor
@oli-obk this should be ready for review now. |
oli-obk
commented
Aug 29, 2022
Contributor
@bors r+ |
bors
commented
Aug 29, 2022
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 29, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#98304 (Add MaybeUninit memset test) - rust-lang#98801 (Add a `File::create_new` constructor) - rust-lang#99821 (Remove separate indexing of early-bound regions) - rust-lang#100239 (remove an ineffective check in const_prop) - rust-lang#100337 (Stabilize `std::io::read_to_string`) - rust-lang#100819 (Make use of `[wrapping_]byte_{add,sub}`) - rust-lang#100934 (Remove a panicking branch from `fmt::builders::PadAdapter`) - rust-lang#101000 (Separate CountIsStar from CountIsParam in rustc_parse_format.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 21, 2022
…, r=oli-obk fix ConstProp handling of written_only_inside_own_block_locals Fixes a regression introduced by rust-lang#100239, which adds an early return and thus skips some code in `visit_terminator` that must be run for soundness. Fixesrust-lang#101973
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 21, 2022
…, r=oli-obk fix ConstProp handling of written_only_inside_own_block_locals Fixes a regression introduced by rust-lang#100239, which adds an early return and thus skips some code in `visit_terminator` that must be run for soundness. Fixesrust-lang#101973
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #100043, only the last two commits are new.
ConstProp has a special check when reading from a local that prevents reading uninit locals. However, if that local flows into
force_allocation, then no check fires and evaluation proceeds. So this check is not really effective at preventing accesses to uninit locals.With #100043,
read_immediateand friends always fail when reading uninit locals, so I don't see why ConstProp would need a separate check. Thus I propose we remove it. This is needed to be able to do #100085.