Uh oh!
There was an error while loading. Please reload this page.
Dont ICE when encountering indeterminate paths in rustdoc - #100310
Closed
compiler-errors wants to merge 1 commit into
Closed
Dont ICE when encountering indeterminate paths in rustdoc#100310compiler-errors wants to merge 1 commit into
compiler-errors wants to merge 1 commit into
Conversation
rust-highfive
commented
Aug 9, 2022
Contributor
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
petrochenkov
commented
Aug 9, 2022
Contributor
|
petrochenkov
commented
Aug 9, 2022
Contributor
It would be better to find where this |
compiler-errors
commented
Aug 9, 2022
ContributorAuthor
Yup, I can do that. The minimized example is pretty small, so doesn't seem too impossible. |
GuillaumeGomez
approved these changes
Aug 23, 2022
bors
commented
Oct 11, 2022
Collaborator
☔ The latest upstream changes (presumably #102926) made this pull request unmergeable. Please resolve the merge conflicts. |
petrochenkov
commented
Oct 15, 2022
Contributor
Superseded by #103096. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if we can avoid having indeterminate paths due to the way that we handle globs (see test), so just suppress the ICE here.
Fixes#100241
Note: The UI test I provided is literally wrong, I don't know how to make a rustdoc test distinguish ICE (bad) and regular fail (good), since we don't have any sort of granularity in failure mode except for
// should-fail, which triggers any time rustdoc fails at all.Perhaps someone knows how to fix this at the compiletest level?