Uh oh!
There was an error while loading. Please reload this page.
Rollup of 14 pull requests - #100346
Merged
Merged
Conversation
This commit ports the scroll locking behavior from the source sidebar to the regular sidebar, and also fixes some bad behavior where opening a "mobile" sidebar, and growing the viewport so that the "desktop" mode without scroll locking is activated, could potentially leave the page stuck. This does not affect the behavior on larger screens. Only small ones, where the sidebar covers up the main content.
I haven't understood the difference between these before, but `@compiler-errors` helped me clear it up. Hopefully this will help other people who've been confused!
…scroll-lock, r=jsha rustdoc: improve scroll locking in the rustdoc mobile sidebars This PR prevents the main content area from scrolling while the mobile sidebar is open on documentation pages (porting the scroll locking behavior from the source sidebar to the regular sidebar), and also fixes some bad behavior where opening a "mobile" sidebar, and growing the viewport so that the "desktop" mode without scroll locking is activated, could potentially leave the page stuck. This does not affect the behavior on larger screens. Only small ones, where the sidebar covers up the main content. Split out from rust-lang#98772
…=camelid rustdoc-json: Remove doc FIXME for Import::id and explain Also add some test and refactor related code a bit. ``@rustbot`` labels +A-rustdoc-json +T-rustdoc
Error on broken pipe but do not backtrace or ICE Windows will report a broken pipe as a normal error which in turn `println!` will panic on. Currently this causes rustc to produce a backtrace and ICE. However, this is not a bug with rustc so a backtrace is overly verbose and ultimately unhelpful to the user. Kind of fixesrust-lang#98700. Although this is admittedly a bit of a hack because at panic time all we have is a string to inspect. On zulip it was suggested that libstd might someday provide a way to indicate a soft panic but that day isn't today.
linker-plugin-lto.md: Correct the name of example c file The final output is linked with `cmain.o`, but we use `main.o` in the example. This patch changes the name to `cmain.c` and `cmain.o` as the "C/C++ code as a dependency in Rust" section.
…ixups, r=davidtwco Some "this expression has a field"-related fixes Each commit does something different and is worth reviewing, but the final diff from `master..HEAD` contains the sum of the changes to the UI tests, since some commits added UI tests "regressions" which were later removed in other commits. The only change I could see adding on top of this is suppressing `Clone::clone` from the "this expression has a field that has this method" suggestion, since it's so commonly implemented by types that it's not worthwhile suggesting in general.
Do not manually craft a span pointing inside a multibyte character. Fixesrust-lang#92462
…=davidtwco Fail gracefully when const pattern is not structural match. Fixesrust-lang#82909
…r-errors Add some high-level docs to `FnCtxt` and `ItemCtxt` I haven't understood the difference between these before, but ``@compiler-errors`` helped me clear it up. Hopefully this will help other people who've been confused! r? `@compiler-errors`
Set tainted errors bit before emitting coerce suggestions. Fixesrust-lang#100246. rust-lang#89576 basically got 99% of the way there but the match typechecking code (which calls `coerce_inner`) also needed a similar fix.
also update anyhow in codegen_cranelift now that is has been un-yanked r? ``@bjorn3``
…=notriddle Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@notriddle`
Mention `unit-test` in MIR opt test README r? `@RalfJung`
…=Dylan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? ``@Dylan-DPC``
…ivate, r=notriddle [rustdoc] Don't render impl blocks with doc comment if they only contain private items by default Fixesrust-lang#100001. cc `@jhpratt` r? `@notriddle`
matthiaskrgr
commented
Aug 9, 2022
MemberAuthor
@bors r+ rollup=never p=9 |
bors
commented
Aug 9, 2022
Collaborator
bors
commented
Aug 10, 2022
Collaborator
bors
commented
Aug 10, 2022
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Aug 10, 2022
Collaborator
📌 Perf builds for each rolled up PR: In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Aug 10, 2022
Collaborator
Finished benchmarking commit (0459d2f): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
FnCtxtandItemCtxt#100256 (Add some high-level docs toFnCtxtandItemCtxt)unit-testin MIR opt test README #100314 (Mentionunit-testin MIR opt test README)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup