Rollup of 7 pull requests by Dylan-DPC · Pull Request #100481 · rust-lang/rust

Dylan-DPC · 2022-08-13T06:51:19Z

Successful merges:

Only point out a single function parameter if we have a single arg incompatibility #99646 (Only point out a single function parameter if we have a single arg incompatibility)
Add Iterator::array_chunks (take N+1) #100026 (Add Iterator::array_chunks (take N+1))
rustc_target: Update some old naming around self contained linking #100126 (rustc_target: Update some old naming around self contained linking)
Rustdoc-Json: Add Path type for traits. #100335 (Rustdoc-Json: Add Path type for traits.)
Suggest the path separator when a dot is used on a trait #100367 (Suggest the path separator when a dot is used on a trait)
Fix HIR pretty printing of let else #100434 (Fix HIR pretty printing of let else)
Remove more Clean trait implementations #100447 (Remove more Clean trait implementations)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

…ce used to create an `IntoIter` from its parts

(suggested in the review of the previous attempt to add `ArrayChunks`)

As explained in the review of the previous attempt to add `ArrayChunks`, adapters that shrink the length can't implement `TrustedLen`.

It doesn't seem to be used at all.

Closesrust-lang#100106

The "fallback" naming pre-dates introduction of `-Clink-self-contained`

…-arg-label, r=estebank Only point out a single function parameter if we have a single arg incompatibility Fixesrust-lang#99635

Add `Iterator::array_chunks` (take N+1) A revival of rust-lang#92393. r? `@Mark-Simulacrum` cc `@rossmacarthur` `@scottmcm` `@the8472` I've tried to address most of the review comments on the previous attempt. The only thing I didn't address is `try_fold` implementation, I've left the "custom" one for now, not sure what exactly should it use.

rustc_target: Update some old naming around self contained linking The "fallback" naming pre-dates introduction of `-Clink-self-contained`. Noticed when reviewing rust-lang#99500. This PR doesn't break any json target spec, but supporting per-linker-flavor startup objects needed by rust-lang#99500 will break them, so maybe next time I'll remove the compatibility names.

…=GuillaumeGomez Rustdoc-Json: Add `Path` type for traits. Avoids using `Type` for trait fields, as a trait must always be a path, and not any other kind of type. `@rustbot` modify labels: +A-rustdoc-json +T-rustdoc Closesrust-lang#100106

Suggest the path separator when a dot is used on a trait Fixesrust-lang#100365. `@rustbot` label A-diagnostics r? diagnostics

…gillot Fix HIR pretty printing of let else Fixesrust-lang#100373Fixesrust-lang#99318Fixesrust-lang#99319

…lan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@Dylan-DPC`

Dylan-DPC · 2022-08-13T06:51:34Z

@bors r+ rollup=never p=5

bors · 2022-08-13T06:51:35Z

📌 Commit 5cdb1e3 has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2022-08-13T07:26:33Z

⌛ Testing commit 5cdb1e3 with merge d5eff2e048313be256218f1bc4ae1ef661759cef...

bors · 2022-08-13T11:41:34Z

💥 Test timed out

GuillaumeGomez · 2022-08-13T11:45:50Z

@bors retry

bors · 2022-08-13T11:45:58Z

⌛ Testing commit 5cdb1e3 with merge a04d77f3d1d1568d61c63ce9a9c629e82de650d1...

rust-log-analyzer · 2022-08-13T11:55:08Z

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

GuillaumeGomez · 2022-08-13T11:58:24Z

@bors retry

bors · 2022-08-13T11:58:33Z

⌛ Testing commit 5cdb1e3 with merge 16359f6694a9780edd2edf6a2b62dd907a5312b8...

rust-log-analyzer · 2022-08-13T12:02:00Z

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2022-08-13T16:13:34Z

💥 Test timed out

rust-log-analyzer · 2022-08-13T16:25:55Z

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2022-08-15T03:43:56Z

☔ The latest upstream changes (presumably #100510) made this pull request unmergeable. Please resolve the merge conflicts.

rossmacarthurand others added 29 commits August 1, 2022 16:39

Add Iterator::array_chunks()
ca3d101

Use array::IntoIter for the ArrayChunks remainder
f548518

Remove array::IntoIter::with_partial -- an artifact of the past, on…
ef72349
…ce used to create an `IntoIter` from its parts

Forward ArrayChunks::next{,_back} to try_{for_each,rfold}
b8b1486
(suggested in the review of the previous attempt to add `ArrayChunks`)

Remove incorrect impl TrustedLen for ArrayChunks
4db628a
As explained in the review of the previous attempt to add `ArrayChunks`, adapters that shrink the length can't implement `TrustedLen`.

Use #[track_caller] to make panic in Iterator::array_chunks nicer
3102b39

Remove Fuse from ArrayChunks implementation
37dfb04
It doesn't seem to be used at all.

Simplify ArrayChunks::is_empty
4c0292c

Simplify ArrayChunks::{,r}fold impls
475e4ba

Use next_chunk in ArrayChunks impl
756bd6e

Rustdoc-Json: Add Path type for traits.
86bdb3e
Closesrust-lang#100106

Suggest path separator when a dot is used on a trait
0fb4ef6

Fix HIR pretty printing of let else
e182d12

remove Clean trait implementation for hir::PathSegment
a65647a

remove Clean trait implementation for hir::BareFnTy
001cc12

address review comments
eb6b729

fill-in tracking issue for feature(iter_array_chunks)
5fbcde1

Point out a single arg if we have a single arg incompatibility
20121fa

And for closures
262644d

Adjust span of closure param
237cbe9

Address nit
c608918

rustc_target: Update some old naming around self contained linking
8fa707a
The "fallback" naming pre-dates introduction of `-Clink-self-contained`

Rollup merge ofrust-lang#99646- compiler-errors:arg-mismatch-single…
6189cba
…-arg-label, r=estebank Only point out a single function parameter if we have a single arg incompatibility Fixesrust-lang#99635

Rollup merge ofrust-lang#100367- fmease:fix-100365, r=compiler-errors
f8d1dcc
Suggest the path separator when a dot is used on a trait Fixesrust-lang#100365. `@rustbot` label A-diagnostics r? diagnostics

Rollup merge ofrust-lang#100434- compiler-errors:issue-100373, r=cj…
60fa217
…gillot Fix HIR pretty printing of let else Fixesrust-lang#100373Fixesrust-lang#99318Fixesrust-lang#99319

Rollup merge ofrust-lang#100447- GuillaumeGomez:rm-clean-impl, r=Dy…
5cdb1e3
…lan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@Dylan-DPC`

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 13, 2022

rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 13, 2022

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 13, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2022

Dylan-DPC closed this Aug 15, 2022

Uh oh!

Uh oh!

Conversation

Dylan-DPC commented Aug 13, 2022

Uh oh!

Dylan-DPC commented Aug 13, 2022

Uh oh!

bors commented Aug 13, 2022

Uh oh!

bors commented Aug 13, 2022

Uh oh!

bors commented Aug 13, 2022

Uh oh!

GuillaumeGomez commented Aug 13, 2022

Uh oh!

bors commented Aug 13, 2022

Uh oh!

rust-log-analyzer commented Aug 13, 2022

Uh oh!

GuillaumeGomez commented Aug 13, 2022

Uh oh!

bors commented Aug 13, 2022

Uh oh!

rust-log-analyzer commented Aug 13, 2022

Uh oh!

bors commented Aug 13, 2022

Uh oh!

rust-log-analyzer commented Aug 13, 2022

Uh oh!

bors commented Aug 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants