support higher-ranked regions in opaque type inference by aliemjay · Pull Request #100503 · rust-lang/rust

aliemjay · 2022-08-13T17:14:05Z

Best reviewed commit by commit.

Cc @WaffleLapkin this may help #93582.

Fixes#96146.
Fixes#97098.
Fixes#97099.

~~Builds on #100375.~~

rust-highfive · 2022-08-13T17:14:08Z

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

aliemjay · 2022-08-13T17:14:30Z

r? @ghost

the8472 · 2022-08-15T14:35:00Z

@bors try @rust-timer queue

rust-timer · 2022-08-15T14:35:02Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-08-15T14:35:09Z

⌛ Trying commit 00ad09a6d887bb405b066fcb3cfd7862016544af with merge 3d24f8fa902ae9abd51f0d08aa8a0d7b2895840f...

bors · 2022-08-15T15:59:16Z

☀️ Try build successful - checks-actions
Build commit: 3d24f8fa902ae9abd51f0d08aa8a0d7b2895840f (3d24f8fa902ae9abd51f0d08aa8a0d7b2895840f)

rust-timer · 2022-08-15T15:59:18Z

Queued 3d24f8fa902ae9abd51f0d08aa8a0d7b2895840f with parent 6ce7609, future comparison URL.

rust-timer · 2022-08-15T17:57:00Z

Finished benchmarking commit (3d24f8fa902ae9abd51f0d08aa8a0d7b2895840f): comparison url.

Instruction count

Primary benchmarks: no relevant changes found
Secondary benchmarks: mixed results

( )	mean¹	max	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.1%	1.5%	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	-0.9%	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: mixed results

( )	mean¹	max	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.2%	1.2%	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	-3.5%	1
All ❌✅ (primary)	-	-	0

Cycles

Results

Primary benchmarks: ❌ relevant regression found
Secondary benchmarks: no relevant changes found

( )	mean¹	max	count²
Regressions ❌ (primary)	2.9%	2.9%	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.9%	2.9%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

When checking `'sup: 'sub`, take placeholder elements into account. This wasn't a problem previously (I hope!) because `eval_outlives` was only used for type_tests, which don't have higher-ranked outlive relations.

aliemjay · 2022-08-15T23:50:52Z

Should be ready now. I've done a couple perf changes that might help.

r? types

bors · 2022-08-21T22:27:45Z

☔ The latest upstream changes (presumably #100847) made this pull request unmergeable. Please resolve the merge conflicts.

spastorino · 2022-09-08T19:15:54Z

r? types

jackh726 · 2022-12-15T15:41:57Z

Nominating to get this moving again (though I imagine this will get delayed until after holidays)

lcnr · 2023-01-18T15:33:45Z

https://rust-lang.zulipchat.com/#narrow/stream/326132-t-types.2Fmeetings/topic/2023-01-18.20meeting/near/322081270

unnominating with the expectation that @aliemjay will either schedule a meeting with niko or assign this PR to me.

anden3 · 2023-05-14T14:19:47Z

Hello @aliemjay! Noticed there's some merge conflicts, what's the status of this PR?

lcnr · 2023-05-15T07:36:11Z

given the time i've spent on this topic recently

r? @lcnr

we probably want to wait on the t-types meeting about opaque types today though before making progress on this

Dylan-DPC · 2023-07-24T11:47:56Z

Blocked on #113575

don't ICE on higher ranked hidden types This shouldn't allow more code to compile, only replaces the ICE with a nicer error message. Fixesrust-lang#97098. Fixesrust-lang#97099. Fixesrust-lang#108399Fixesrust-lang#104196Fixesrust-lang#113481Fixesrust-lang#103186Fixesrust-lang#100818 r? `@lcnr` (because you showed interest in rust-lang#100503 :)

Dylan-DPC · 2023-10-07T10:17:46Z

No longer blocked as the pr it was blocked on, is merged

Dylan-DPC · 2024-02-04T13:29:01Z

@aliemjay any updates on this?

…r=lcnr test that we do not support higher-ranked regions in opaque type inference We already do all the right checks in `check_opaque_type_parameter_valid`, and we have done so since at least 2 years. I collected the tests from rust-lang#116935 and rust-lang#100503 and added some more cc rust-lang#96146 r? `@lcnr`

Rollup merge of rust-lang#121386 - oli-obk:no_higher_ranked_opaques, r=lcnr test that we do not support higher-ranked regions in opaque type inference We already do all the right checks in `check_opaque_type_parameter_valid`, and we have done so since at least 2 years. I collected the tests from rust-lang#116935 and rust-lang#100503 and added some more cc rust-lang#96146 r? `@lcnr`

Dylan-DPC · 2024-03-09T18:05:07Z

Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks

rust-highfive assigned wesleywiser Aug 13, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 13, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2022

compiler-errors unassigned wesleywiser Aug 13, 2022

aliemjay force-pushed the opaque_higher_ranked branch from 6d8101f to 00ad09aCompare August 15, 2022 13:42

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 15, 2022

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 15, 2022

aliemjay added 5 commits August 15, 2022 22:53

[REFACTOR] add fn finalize_opaque_types
73a3c7e

[REFACTOR] use OpaqueTypeMap type alias
0329621

fix eval_outlives for higher-ranked regions
3a423b7
When checking `'sup: 'sub`, take placeholder elements into account. This wasn't a problem previously (I hope!) because `eval_outlives` was only used for type_tests, which don't have higher-ranked outlive relations.

support higher-ranked region in member constraints
fcbd6a3

support higher-ranked regions in opaque type inference
e6b62a0

aliemjay changed the title ~~support higher-ranked regions in opaque type inferece~~support higher-ranked regions in opaque type inferenceAug 15, 2022

aliemjay force-pushed the opaque_higher_ranked branch from 00ad09a to e6b62a0Compare August 15, 2022 23:46

aliemjay marked this pull request as ready for review August 15, 2022 23:47

rust-highfive assigned spastorino Aug 15, 2022

spastorino removed their assignment Sep 8, 2022

rustbot removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 15, 2022

jackh726 added the I-types-nominated Nominated for discussion during a types team meeting. label Dec 15, 2022

lcnr removed the I-types-nominated Nominated for discussion during a types team meeting. label Jan 18, 2023

anden3 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2023

rustbot assigned lcnr and unassigned nikomatsakis May 15, 2023

aliemjay mentioned this pull request Jul 11, 2023
don't ICE on higher ranked hidden types #113575
Merged

Dylan-DPC added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 24, 2023

Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 7, 2023

compiler-errors mentioned this pull request Nov 6, 2023
New 2024-edition impl Trait lifetime capture rules means opaques now capture higher-ranked lifetimes #117647
Closed

oli-obk mentioned this pull request Feb 21, 2024
test that we do not support higher-ranked regions in opaque type inference #121386
Merged

Dylan-DPC closed this Mar 9, 2024

Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2024

traviscross mentioned this pull request Mar 19, 2024
Stabilize associated type position impl Trait (ATPIT) #120700
Open
3 tasks

Uh oh!

Uh oh!

Conversation

aliemjay commented Aug 13, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Aug 13, 2022

Uh oh!

aliemjay commented Aug 13, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the8472 commented Aug 15, 2022

Uh oh!

rust-timer commented Aug 15, 2022

Uh oh!

bors commented Aug 15, 2022

Uh oh!

bors commented Aug 15, 2022

Uh oh!

rust-timer commented Aug 15, 2022

Uh oh!

rust-timer commented Aug 15, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

aliemjay commented Aug 15, 2022

Uh oh!

bors commented Aug 21, 2022

Uh oh!

spastorino commented Sep 8, 2022

Uh oh!

jackh726 commented Dec 15, 2022

Uh oh!

lcnr commented Jan 18, 2023

Uh oh!

anden3 commented May 14, 2023

Uh oh!

lcnr commented May 15, 2023

Uh oh!

Dylan-DPC commented Jul 24, 2023

Uh oh!

Dylan-DPC commented Oct 7, 2023

Uh oh!

Dylan-DPC commented Feb 4, 2024

Uh oh!

Dylan-DPC commented Mar 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

aliemjay commented Aug 13, 2022•
edited
Loading

aliemjay commented Aug 13, 2022•
edited
Loading