Skip to content

update Miri - #100682

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:miri
Aug 18, 2022
Merged

update Miri#100682
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:miri

Conversation

@RalfJung

@RalfJungRalfJung commented Aug 17, 2022

Copy link
Copy Markdown
Member

Fixes#100614
r? @ghost

@rustbot

rustbot commented Aug 17, 2022

Copy link
Copy Markdown
Collaborator

The Miri submodule was changed

cc @rust-lang/miri

@RalfJung

RalfJung commented Aug 17, 2022

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=1

@bors

bors commented Aug 17, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 2c9baf7 has been approved by RalfJung

It is now in the queue for this repository.

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 17, 2022
@bors

bors commented Aug 17, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2c9baf7 with merge 2d99ecd0185c64497550787b4a261165d88d8377...

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 17, 2022
@matthiaskrgr
Rollup merge ofrust-lang#100682- RalfJung:miri, r=RalfJung
e76d218
update Miri
Fixesrust-lang#100614
r? `@ghost`
@matthiaskrgrmatthiaskrgr mentioned this pull request Aug 17, 2022
Closed
@bors

bors commented Aug 17, 2022

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 17, 2022
@matthiaskrgr

matthiaskrgr commented Aug 17, 2022

Copy link
Copy Markdown
Member

@bors retry timeout

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 17, 2022
@matthiaskrgr
Rollup merge ofrust-lang#100682- RalfJung:miri, r=RalfJung
1254057
update Miri
Fixesrust-lang#100614
r? `@ghost`
@matthiaskrgrmatthiaskrgr mentioned this pull request Aug 17, 2022
Closed
@rust-log-analyzer

rust-log-analyzer commented Aug 17, 2022

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors

bors commented Aug 18, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2c9baf7 with merge 4993a76db9d295f5d2b9ce2a4946d841c01e7acb...

@bors

bors commented Aug 18, 2022

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 18, 2022
@rust-log-analyzer

rust-log-analyzer commented Aug 18, 2022

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

@RalfJung

RalfJung commented Aug 18, 2022

Copy link
Copy Markdown
MemberAuthor

@bors retry timeout in x86_64-mingw-1

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2022
@bors

bors commented Aug 18, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2c9baf7 with merge bb99e6f...

@bors

bors commented Aug 18, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing bb99e6f to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 18, 2022
@bors
bors merged commit bb99e6f into rust-lang:masterAug 18, 2022
@rustbotrustbot added this to the 1.65.0 milestone Aug 18, 2022
@rust-highfive

rust-highfive commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #100682!

Tested on commit bb99e6f.
Direct link to PR: #100682

🎉 miri on windows: build-fail → test-pass (cc @RalfJung@oli-obk).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung@oli-obk).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 18, 2022
@rust-highfive
📣 Toolstate changed byrust-lang/rust#100682!
a35cce2
Tested on commit rust-lang/rust@bb99e6f.
Direct link to PR: <rust-lang/rust#100682>
🎉 miri on windows: build-fail → test-pass (cc @RalfJung@oli-obk).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung@oli-obk).
@rust-timer

rust-timer commented Aug 18, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (bb99e6f): comparison url.

Instruction count

  • Primary benchmarks: ✅ relevant improvements found
  • Secondary benchmarks: no relevant changes found
mean1maxcount2
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.9%-0.9%2
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-0.9%-0.9%2

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1maxcount2
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		2.2%3.2%2
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-2.3%-2.6%3
All ❌✅ (primary)--0

Cycles

Results
  • Primary benchmarks: ✅ relevant improvement found
  • Secondary benchmarks: ✅ relevant improvement found
mean1maxcount2
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-3.1%-3.1%1
Improvements ✅
(secondary)		-2.3%-2.3%1
All ❌✅ (primary)-3.1%-3.1%1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change↩↩2↩3

  2. number of relevant changes↩↩2↩3

@RalfJung
RalfJung deleted the miri branch August 18, 2022 17:09
@RalfJung

RalfJung commented Aug 18, 2022

Copy link
Copy Markdown
MemberAuthor

Looks like a noisy benchmark, this certainly didn't change compiler performance.

@moxianmoxian mentioned this pull request Mar 20, 2025
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#100611

7 participants

@RalfJung@rustbot@bors@matthiaskrgr@rust-log-analyzer@rust-highfive@rust-timer