Uh oh!
There was an error while loading. Please reload this page.
Catch overflow early - #100757
Merged
Merged
Conversation
rust-highfive
commented
Aug 19, 2022
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
petrochenkov
commented
Aug 19, 2022
Contributor
I don't understand why this check needs to be performed in this specific place but not in others. |
ouz-a
commented
Aug 19, 2022
ContributorAuthor
There is a similar check above, so I thought it was appropriate to put it here 😅 |
ouz-a
commented
Aug 19, 2022
ContributorAuthor
Weird rust-highfive assigned you again 🤷♂️ r? @jackh726 |
jackh726
commented
Aug 20, 2022
Member
@bors r+ |
bors
commented
Aug 20, 2022
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 22, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#93162 (Std module docs improvements) - rust-lang#99386 (Add tests that check `Vec::retain` predicate execution order.) - rust-lang#99915 (Recover keywords in trait bounds) - rust-lang#100694 (Migrate rustc_ast_passes diagnostics to `SessionDiagnostic` and translatable messages (first part)) - rust-lang#100757 (Catch overflow early) Failed merges: - rust-lang#99917 (Move Error trait into core) r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Aug 23, 2022
This was referenced Aug 24, 2022
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2022
…rors Reverts check done by rust-lang#100757 As my `fix` caused more issues than it resolved it's better to revert it. ( rust-lang#103274rust-lang#104322rust-lang#104606) r? `@compiler-errors` Reopens rust-lang#95134
Aaron1011 pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…rors Reverts check done by rust-lang#100757 As my `fix` caused more issues than it resolved it's better to revert it. ( rust-lang#103274rust-lang#104322rust-lang#104606) r? `@compiler-errors` Reopens rust-lang#95134
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although this code should raise an overflow error, it didn't because check_recursion_limit it checks for
depth = 128but not for129which should have triggered the overflow error. Anyways this catches that error early.Fixes#95134