Uh oh!
There was an error while loading. Please reload this page.
Migrate rustc_plugin_impl to SessionDiagnostic - #100768
Merged
Merged
Conversation
rust-highfive
commented
Aug 19, 2022
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon. Please see the contribution instructions for more information. |
petermused
commented
Aug 19, 2022
ContributorAuthor
r? @davidtwco |
This comment was marked as resolved.
This comment was marked as resolved.
davidtwco
approved these changes
Aug 20, 2022
davidtwco
left a comment
Member
There was a problem hiding this comment.
LGTM, r=me once rebased on #[fatal(..)] support landing.
Uh oh!
There was an error while loading. Please reload this page.
petermusedforce-pushed
the
plugin-impl-translation
branch
from
August 22, 2022 15:35
bf3dc6e to
8c2413cComparepetermused
marked this pull request as ready for review
August 22, 2022 16:03
rustbot
commented
Aug 22, 2022
Collaborator
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
davidtwco
commented
Aug 22, 2022
Member
@bors r+ |
bors
commented
Aug 22, 2022
Collaborator
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 23, 2022
… r=davidtwco Migrate `rustc_plugin_impl` to `SessionDiagnostic` Migration of the `rustc_plugin_impl` crate. ~Draft PR because it is blocked on rust-lang#100694 for `#[fatal(...)]` support~ (this has been merged, and I've changed over to `#[diag(...)]` now too), but I would also like to know if what I did with `LoadPluginError` is okay, because all it does is display the error message from `libloading` ([See conversation on zulip](https://rust-lang.zulipchat.com/#narrow/stream/147480-t-compiler.2Fwg-diagnostics/topic/.23100717.20diagnostic.20translation/near/294327843)). This crate is apparently for a deprecated feature which is used by servo, so I don't know how much this matters anyway.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 23, 2022
Rollup of 9 pull requests Successful merges: - rust-lang#99249 (Do not re-parse function signatures to suggest generics) - rust-lang#100309 (Extend comma suggestion to cases where fields arent missing) - rust-lang#100368 (InferCtxt tainted_by_errors_flag should be Option<ErrorGuaranteed>) - rust-lang#100768 (Migrate `rustc_plugin_impl` to `SessionDiagnostic`) - rust-lang#100835 (net listen backlog update, follow-up from rust-lang#97963.) - rust-lang#100851 (Fix rustc_parse_format precision & width spans) - rust-lang#100857 (Refactor query modifier parsing) - rust-lang#100907 (Fix typo in UnreachableProp) - rust-lang#100909 (Minor `ast::LitKind` improvements) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of the
rustc_plugin_implcrate.Draft PR because it is blocked on #100694 for(this has been merged, and I've changed over to#[fatal(...)]support#[diag(...)]now too), but I would also like to know if what I did withLoadPluginErroris okay, because all it does is display the error message fromlibloading(See conversation on zulip). This crate is apparently for a deprecated feature which is used by servo, so I don't know how much this matters anyway.