Skip to content

Suggest adding a reference to a trait assoc item - #100769

Merged
bors merged 2 commits into
rust-lang:masterfrom
TaKO8Ki:suggest-adding-reference-to-trait-assoc-item
Aug 20, 2022
Merged

Suggest adding a reference to a trait assoc item#100769
bors merged 2 commits into
rust-lang:masterfrom
TaKO8Ki:suggest-adding-reference-to-trait-assoc-item

Conversation

@TaKO8Ki

Copy link
Copy Markdown
Member

fixes#100289

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 19, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2022
});
let mut try_borrowing = |old_pred: ty::PolyTraitPredicate<'tcx>,
blacklist: &[DefId]|
-> bool {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting is a bit unorthodox here, but if rustfmt says so...

Comment threadcompiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs Outdated
Comment threadcompiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs Outdated
@cjgillot

Copy link
Copy Markdown
Contributor

r=me with this naming nits addressed.

@cjgillotcjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2022
@TaKO8Ki

Copy link
Copy Markdown
MemberAuthor

@bors r=cjgillot

@bors

bors commented Aug 20, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit a311b8a has been approved by cjgillot

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 20, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 20, 2022
…o-trait-assoc-item, r=cjgillot
Suggest adding a reference to a trait assoc item
fixesrust-lang#100289
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 20, 2022
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#97963 (net listen backlog set to negative on Linux.)
- rust-lang#99935 (Reenable disabled early syntax gates as future-incompatibility lints)
- rust-lang#100129 (add miri-test-libstd support to libstd)
- rust-lang#100500 (Ban references to `Self` in trait object substs for projection predicates too.)
- rust-lang#100636 (Revert "Revert "Allow dynamic linking for iOS/tvOS targets."")
- rust-lang#100718 ([rustdoc] Fix item info display)
- rust-lang#100769 (Suggest adding a reference to a trait assoc item)
- rust-lang#100777 (elaborate how revisions work with FileCheck stuff in src/test/codegen)
- rust-lang#100796 (Refactor: remove unnecessary string searchings)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7f02896 into rust-lang:masterAug 20, 2022
@rustbotrustbot added this to the 1.65.0 milestone Aug 20, 2022
@TaKO8Ki
TaKO8Ki deleted the suggest-adding-reference-to-trait-assoc-item branch August 21, 2022 02:24
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Aug 21, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad suggestion for &mut in combination with Default (maybe also other traits)

5 participants

@TaKO8Ki@rust-highfive@cjgillot@bors@rustbot