Uh oh!
There was an error while loading. Please reload this page.
save_analysis: Migrate diagnostic - #100780
Merged
Merged
Conversation
rust-highfive
commented
Aug 19, 2022
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
commented
Aug 19, 2022
Collaborator
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank
|
lcnr
commented
Aug 20, 2022
Contributor
r? @davidtwco |
davidtwco
approved these changes
Aug 20, 2022
davidtwco
left a comment
Member
There was a problem hiding this comment.
LGTM! r=me once all the dependencies have landed and those commits are removed, etc, etc.
This comment was marked as resolved.
This comment was marked as resolved.
davidtwco
commented
Aug 23, 2022
Member
fatal support has landed now, so you should be able to rebase and continue to work on this :) |
Add impls of `IntoDiagnosticArg` for `std::io::Error`, `std::path::Path` and `std::path::PathBuf`. Signed-off-by: David Wood <david.wood@huawei.com>
wonchuleeforce-pushed
the
translation_save_analysis
branch
from
August 23, 2022 21:52
99fc892 to
c18503fComparewonchulee
commented
Aug 23, 2022
ContributorAuthor
davidtwco
commented
Aug 24, 2022
Member
bors
commented
Aug 24, 2022
Collaborator
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 24, 2022
…s, r=davidtwco save_analysis: Migrate diagnostic * Migrate the `rustc_save_analysis` crate's diagnostic to translatable diagnostic structs. Depends on rust-lang#100694 and rust-lang#100754 for #[fatal(..)] support, then rust-lang@aa68eb4, rust-lang@f5219a3, rust-lang@7da52f6 can be removed. (I copied commits from rust-lang#100754)
This was referenced Aug 24, 2022
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 25, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#99332 (Stabilize `#![feature(label_break_value)]`) - rust-lang#99954 (let-else: break out to one scope higher for let-else) - rust-lang#100188 (Parser will not suggest invalid expression when use public) - rust-lang#100780 (save_analysis: Migrate diagnostic) - rust-lang#100808 (Migrate `rustc_interface` diagnostics ) - rust-lang#100921 (Add a warning about `Option/Result::and()` being eagerly evaluated) - rust-lang#100960 (rustdoc: ayu code color selector more specific) - rust-lang#100964 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustc_save_analysiscrate's diagnostic to translatable diagnostic structs.Depends on #100694 and #100754 for #[fatal(..)] support, then aa68eb4, f5219a3, 7da52f6 can be removed. (I copied commits from #100754)