Skip to content

Export Cancel from std::os::fortanix_sgx::usercalls::raw - #100885

Merged
bors merged 1 commit into
rust-lang:masterfrom
mzohreva:mz/sgx-export-cancel-type
Aug 28, 2022
Merged

Export Cancel from std::os::fortanix_sgx::usercalls::raw#100885
bors merged 1 commit into
rust-lang:masterfrom
mzohreva:mz/sgx-export-cancel-type

Conversation

@mzohreva

@mzohrevamzohreva commented Aug 22, 2022

Copy link
Copy Markdown

This was missed in #100642

cc @raoulstrackx and @jethrogb

@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 22, 2022
@rust-highfive

rust-highfive commented Aug 22, 2022

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot

rustbot commented Aug 22, 2022

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2022
@raoulstrackx

raoulstrackx commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

Looks good to me!

@Mark-Simulacrum

Mark-Simulacrum commented Aug 27, 2022

Copy link
Copy Markdown
Member

@bors r+ rollup

I think formally we'd want an ACP but these are fortanix-specific APIs which are not really thoroughly tracked in #56975 in any case, so seems OK. Everything is unstable.

@bors

bors commented Aug 27, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 85b3df2 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 28, 2022
@matthiaskrgr
Rollup merge ofrust-lang#100885- mzohreva:mz/sgx-export-cancel-type…
9ccd9c3
…, r=Mark-Simulacrum
Export Cancel from std::os::fortanix_sgx::usercalls::raw
This was missed in rust-lang#100642
cc `@raoulstrackx` and `@jethrogb`
This was referenced Aug 28, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 28, 2022
@bors
Auto merge ofrust-lang#101115- matthiaskrgr:rollup-iy14ztr, r=matth…
3fdd578
…iaskrgr
Rollup of 13 pull requests
Successful merges:
- rust-lang#97015 (std::io: migrate ReadBuf to BorrowBuf/BorrowCursor)
- rust-lang#98301 (Add GDB/LLDB pretty-printers for NonZero types)
- rust-lang#99570 (Box::from(slice): Clarify that contents are copied)
- rust-lang#100296 (Add standard C error function aliases to last_os_error)
- rust-lang#100520 (Add mention of `BufReader` in `Read::bytes` docs)
- rust-lang#100885 (Export Cancel from std::os::fortanix_sgx::usercalls::raw)
- rust-lang#100955 (Some papercuts on error::Error)
- rust-lang#101002 (Provide structured suggestion for `hashmap[idx] = val`)
- rust-lang#101038 (no alignment check during interning)
- rust-lang#101055 (Use smaller span for suggestions)
- rust-lang#101091 (Extend attrs if local_def_id exists)
- rust-lang#101098 (rustc_middle: Remove `Visibility::Invisible`)
- rust-lang#101102 (unstable-book-gen: use std::fs::write)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1547638 into rust-lang:masterAug 28, 2022
@rustbotrustbot added this to the 1.65.0 milestone Aug 28, 2022
@mzohreva
mzohreva deleted the mz/sgx-export-cancel-type branch August 29, 2022 15:31
@raoulstrackxraoulstrackx mentioned this pull request Sep 20, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

6 participants

@mzohreva@rust-highfive@rustbot@raoulstrackx@Mark-Simulacrum@bors