Rollup of 11 pull requests by JohnTitor · Pull Request #101074 · rust-lang/rust

JohnTitor · 2022-08-27T04:14:27Z

Successful merges:

Stabilize const_ptr_offset_from. #96240 (Stabilize const_ptr_offset_from.)
Make forward compatibility lint deprecated_cfg_attr_crate_type_name deny by default #99784 (Make forward compatibility lint deprecated_cfg_attr_crate_type_name deny by default)
Fix wrong compiletest filters on Windows #100811 (Fix wrong compiletest filters on Windows)
Smaller improvements of tidy and the unicode generator #100924 (Smaller improvements of tidy and the unicode generator)
Update documentation for write! and writeln! #100953 (Update documentation for write! and writeln!)
rustdoc: omit start/end tags for empty item description blocks #101018 (rustdoc: omit start/end tags for empty item description blocks)
rustdoc: remove unused CSS for hidden-by-*-hider #101044 (rustdoc: remove unused CSS for hidden-by-*-hider)
rustdoc: remove incorrect CSS selector .impl-items table td #101046 (rustdoc: remove incorrect CSS selector .impl-items table td)
Merge implementations of HIR fn_decl and fn_sig. #101057 (Merge implementations of HIR fn_decl and fn_sig.)
rustdoc: remove empty extern_crates and type="text/javascript" on script #101062 (rustdoc: remove empty extern_crates and type="text/javascript" on script)
Merge duplicated CSS rules #101063 (Merge duplicated CSS rules)

Failed merges:

Use smaller span for suggestions #101055 (Use smaller span for suggestions)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

…eny by default

Reduce duplication by moving fetching logic into a dedicated function.

`writeln!` already includes a reference to `write!` for more information, so remove duplicated information.

Stabilization has been completed [here](rust-lang#92980 (comment)) with a FCP.

Related to rust-lang#100952 This is definitely not a complete solution, but it does shrink keysyms/index.html on smithay from 620K to 516K.

This CSS seems to have become obsolete with the move to `<details>` tags, and its corresponding JavaScript was removed in aee054d

Fixesrust-lang#100994 This selector was added in c7312fb. The bug can be seen at <https://doc.rust-lang.org/1.27.0/alloc/slice/trait.SliceIndex.html#foreign-impls>. This rule was added to help with a `<table>` that was used for displaying the function signature [src] lockup. That lockup was changed in 34bd2b8 to use flexbox instead, leaving this selector unused (at least, for its original purpose).

Like rust-lang#101023, this removes an attribute with a default value.

…ffset_from, r=Mark-Simulacrum Stabilize `const_ptr_offset_from`. Stabilization has been completed [here](rust-lang#92980 (comment)) with a FCP. Closesrust-lang#92980.

…, r=Mark-Simulacrum Make forward compatibility lint deprecated_cfg_attr_crate_type_name deny by default Turns the forward compatibility lint added by rust-lang#83744 to deprecate `cfg_attr` usage with `#![crate_type]` and `#![crate_name]` attributes into deny by default. Copying the example from rust-lang#83744: ```Rust #![crate_type = "lib"] // remains working #![cfg_attr(foo, crate_type = "bin")] // will stop working ``` Over 8 months have passed since rust-lang#83744 was merged so I'd say this gives ample time for people to have been warned, so we can make the warning stronger. No usage was found via grep.app except for one, which was in an unmaintained code base that didn't seem to be used in the open source eco system. The crater run conducted in rust-lang#83744 also didn't show up anything. cc rust-lang#91632 - tracking issue for the lint

Fix wrong compiletest filters on Windows As discussed in [rust-lang#79334](rust-lang#79334), when calling e.g. ``` python x.py test src/test/ui/expr/compound-assignment/eval-order.rs ``` on Windows, compiletest passes the filter `expr/compound-assignment/eval-order.rs` to libtest, which instead should be `expr\compound-assignment\eval-order.rs`, as that is the file found when collecting tests. This is what I fixed. I'm not sure how to organize a test for this. Any suggestions?

…mulacrum Smaller improvements of tidy and the unicode generator

…mulacrum Update documentation for `write!` and `writeln!` rust-lang#37472 added this documentation, but it needs updating: - Remove some documentation duplicated between `writeln!` and `write!` - Update `write!` docs: can now import traits as `_` to avoid conflicts - Expand example to show how to implement qualified trait names

…block-short, r=GuillaumeGomez rustdoc: omit start/end tags for empty item description blocks Related to rust-lang#100952 This is definitely not a complete solution, but it does shrink keysyms/index.html on smithay from 620K to 516K.

… r=jsha rustdoc: remove unused CSS for `hidden-by-*-hider` This CSS seems to have become obsolete with the move to `<details>` tags, and its corresponding JavaScript was removed in aee054d

rustdoc: remove incorrect CSS selector `.impl-items table td` Fixesrust-lang#100994 This selector was added in c7312fb. The bug can be seen at <https://doc.rust-lang.org/1.27.0/alloc/slice/trait.SliceIndex.html#foreign-impls>. This rule was added to help with a `<table>` that was used for displaying the function signature [src] lockup. That lockup was changed in 34bd2b8 to use flexbox instead, leaving this selector unused (at least, for its original purpose).

…rors Merge implementations of HIR fn_decl and fn_sig.

…t, r=GuillaumeGomez rustdoc: remove empty extern_crates and type="text/javascript" on script Like rust-lang#101023, this removes an attribute with a default value.

…s, r=notriddle Merge duplicated CSS rules I used the [stylelint](https://stylelint.io/user-guide/configure) tool to check for duplicated CSS rules in order to merge them. r? `@notriddle`

JohnTitor · 2022-08-27T04:14:47Z

@bors r+ p=11 rollup=never

bors · 2022-08-27T04:14:49Z

📌 Commit bd89372 has been approved by JohnTitor

It is now in the queue for this repository.

bors · 2022-08-27T06:12:20Z

⌛ Testing commit bd89372 with merge d0e1491...

bors · 2022-08-27T08:53:18Z

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing d0e1491 to master...

rust-timer · 2022-08-27T08:56:37Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#101063	2d6d6d041c3650f75bc9fc3327e052bdd8f0335f
#101062	3b763375dece3cfd9a92be041e8670a5b17fdce2
#101057	8b5307d08be524b37deb6f838ab353673f622857
#101046	5fc168c617242c05dbd7785f00a68eb12216d36e
#101044	f6039fe4c43131eeb34bb2b790468786fd075db2
#101018	9b9d8d1c5bf807e9bf402108d2e6dc5fb06d9f89
#100953	ad3480d950681090bbb64979e840bc88917a7d64
#100924	bf8fb3d592c55d22c1d7ed11422cd12cb5984013
#100811	2c214ac9846ef078e8dbc38d9041b7454291b513
#99784	9bf5526d1fc575da01a314132c5fb41c61980b41
#96240	48998613c30a185251b848d67ffd97849490d432

previous master: 9845f4c47e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-08-28T10:25:36Z

Finished benchmarking commit (d0e1491): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.5%	[-1.5%, -1.5%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	3.5%	[3.0%, 4.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.5%	[3.0%, 4.0%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	3.2%	[3.2%, 3.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.9%	[1.9%, 1.9%]	1

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

est31and others added 28 commits July 27, 2022 03:20

Make forward compatibility lint deprecated_cfg_attr_crate_type_name d…
152c851
…eny by default

Correct test-args to compiletest on Windows
8998024

Use direct pointer to filter_dirs function
6a1f7af

Simplify unicode_downloads.rs
0a6af98
Reduce duplication by moving fetching logic into a dedicated function.

Change hint to correct path
754b3e7

Remove some documentation duplicated between writeln! and write!
a788650
`writeln!` already includes a reference to `write!` for more information, so remove duplicated information.

Update write! docs: can now import traits as _ to avoid conflicts
3c8618f

Expand example to show how to implement qualified trait names
589db1f

Clarify comment to fit as _ better
ae937cc

Stabilize const_ptr_offset_from.
ad93272
Stabilization has been completed [here](rust-lang#92980 (comment)) with a FCP.

Do not include const_ptr_sub_ptr in this stabilization
69ad634

rustdoc: omit start/end tags for empty item description blocks
e7b7f88
Related to rust-lang#100952 This is definitely not a complete solution, but it does shrink keysyms/index.html on smithay from 620K to 516K.

rustdoc: remove unused CSS for hidden-by-*-hider
832fd23
This CSS seems to have become obsolete with the move to `<details>` tags, and its corresponding JavaScript was removed in aee054d

Merge implementations of HIR fn_decl and fn_sig.
20012ea

rustdoc: remove empty extern_crates and type="text/javascript" on script
52582d3
Like rust-lang#101023, this removes an attribute with a default value.

Merge duplicated CSS rules
a74f453

Rollup merge ofrust-lang#96240- fee1-dead-contrib:stabilize_const_o…
539e408
…ffset_from, r=Mark-Simulacrum Stabilize `const_ptr_offset_from`. Stabilization has been completed [here](rust-lang#92980 (comment)) with a FCP. Closesrust-lang#92980.

Rollup merge ofrust-lang#100924- est31:closure_to_fn_ptr, r=Mark-Si…
e31bedc
…mulacrum Smaller improvements of tidy and the unicode generator

Rollup merge ofrust-lang#101044- notriddle:notriddle/css-hidden-by,…
84f5ccd
… r=jsha rustdoc: remove unused CSS for `hidden-by-*-hider` This CSS seems to have become obsolete with the move to `<details>` tags, and its corresponding JavaScript was removed in aee054d

Rollup merge ofrust-lang#101057- cjgillot:one-fn-sig, r=compiler-er…
aa6b750
…rors Merge implementations of HIR fn_decl and fn_sig.

Rollup merge ofrust-lang#101062- notriddle:notriddle/text-javascrip…
bdbbbe6
…t, r=GuillaumeGomez rustdoc: remove empty extern_crates and type="text/javascript" on script Like rust-lang#101023, this removes an attribute with a default value.

Rollup merge ofrust-lang#101063- GuillaumeGomez:merge-duplicated-cs…
bd89372
…s, r=notriddle Merge duplicated CSS rules I used the [stylelint](https://stylelint.io/user-guide/configure) tool to check for duplicated CSS rules in order to merge them. r? `@notriddle`

rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 27, 2022

rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 27, 2022

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 27, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 27, 2022

bors merged commit d0e1491 into rust-lang:masterAug 27, 2022

rustbot added this to the 1.65.0 milestone Aug 27, 2022

JohnTitor deleted the rollup-zwznihq branch August 27, 2022 09:01

bors mentioned this pull request Aug 27, 2022
Rollup of 9 pull requests #101033
Closed

Navigation Menu

Uh oh!

Uh oh!

Rollup of 11 pull requests - #101074

Rollup of 11 pull requests#101074
bors merged 28 commits into
rust-lang:masterfrom
JohnTitor:rollup-zwznihq

JohnTitor commented Aug 27, 2022

Uh oh!

JohnTitor commented Aug 27, 2022

Uh oh!

bors commented Aug 27, 2022

Uh oh!

bors commented Aug 27, 2022

Uh oh!

bors commented Aug 27, 2022

Uh oh!

rust-timer commented Aug 27, 2022

Uh oh!

rust-timer commented Aug 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Uh oh!

Conversation

JohnTitor commented Aug 27, 2022

Uh oh!

JohnTitor commented Aug 27, 2022

Uh oh!

bors commented Aug 27, 2022

Uh oh!

bors commented Aug 27, 2022

Uh oh!

bors commented Aug 27, 2022

Uh oh!

rust-timer commented Aug 27, 2022

Uh oh!

rust-timer commented Aug 28, 2022

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants