Skip to content

Fix compile errors for uwp-windows-msvc targets - #101481

Merged
bors merged 1 commit into
rust-lang:masterfrom
ChrisDenton:uwp-fix
Sep 7, 2022
Merged

Fix compile errors for uwp-windows-msvc targets#101481
bors merged 1 commit into
rust-lang:masterfrom
ChrisDenton:uwp-fix

Conversation

@ChrisDenton

@ChrisDentonChrisDenton commented Sep 6, 2022

Copy link
Copy Markdown
Member

Fixes#101480

@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 6, 2022
@rustbot

rustbot commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive

rust-highfive commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

@ChrisDenton: no appropriate reviewer found, use r? to override

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2022
@ChrisDenton

ChrisDenton commented Sep 6, 2022

Copy link
Copy Markdown
MemberAuthor

r? libs

@ChrisDenton

ChrisDenton commented Sep 6, 2022

Copy link
Copy Markdown
MemberAuthor

There are actually two small issues here but one of them is fixed in another PR so I'll only focus on the other one to avoid merge conflicts.

@thomcc

thomcc commented Sep 6, 2022

Copy link
Copy Markdown
Member

Oof!

@bors r+ rollup

@bors

bors commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 774e712 has been approved by thomcc

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2022
@thomccthomcc mentioned this pull request Sep 6, 2022
Merged
@JohnTitorJohnTitor mentioned this pull request Sep 6, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2022
@bors
Auto merge ofrust-lang#101508- JohnTitor:rollup-i5i2vqc, r=JohnTitor
8c41305
Rollup of 8 pull requests
Successful merges:
- rust-lang#101451 (Add incremental test for changing struct name in assoc type.)
- rust-lang#101468 (fix RPIT ICE for implicit HRTB when missing dyn)
- rust-lang#101481 (Fix compile errors for uwp-windows-msvc targets)
- rust-lang#101484 (Remove dead broken code from const zst handling in backends)
- rust-lang#101486 (Add list of recognized repr attributes to the unrecognized repr error)
- rust-lang#101488 (rustdoc: remove unused CSS `#results > table`)
- rust-lang#101491 (rustdoc: remove outdated CSS `.sub-variant > div > .item-info`)
- rust-lang#101497 (:arrow_up: rust-analyzer)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 923dae5 into rust-lang:masterSep 7, 2022
@rustbotrustbot added this to the 1.65.0 milestone Sep 7, 2022
@ChrisDenton
ChrisDenton deleted the uwp-fix branch March 9, 2024 04:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thomccthomcc

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

std library compile errors for uwp-windows-msvc targets

5 participants

@ChrisDenton@rustbot@rust-highfive@thomcc@bors