Skip to content

Allow lint passes to be bound by TyCtxt - #101501

Merged
bors merged 1 commit into
rust-lang:masterfrom
Jarcho:tcx_lint_passes
Sep 8, 2022
Merged

Allow lint passes to be bound by TyCtxt#101501
bors merged 1 commit into
rust-lang:masterfrom
Jarcho:tcx_lint_passes

Conversation

@Jarcho

Copy link
Copy Markdown
Contributor

This will allow storing things like Ty<'tcx> inside late lint passes. It's already possible to store various id types so they're already implicitly bound to a specific TyCtxt.

r? rust-lang/compiler

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 6, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2022
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Comment threadcompiler/rustc_lint/src/context.rs
@davidtwco

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 7, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 0126f7f has been approved by davidtwco

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Sep 8, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 8, 2022
Allow lint passes to be bound by `TyCtxt`
This will allow storing things like `Ty<'tcx>` inside late lint passes. It's already possible to store various id types so they're already implicitly bound to a specific `TyCtxt`.
r? rust-lang/compiler
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 8, 2022
Allow lint passes to be bound by `TyCtxt`
This will allow storing things like `Ty<'tcx>` inside late lint passes. It's already possible to store various id types so they're already implicitly bound to a specific `TyCtxt`.
r? rust-lang/compiler
This was referenced Sep 8, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 8, 2022
Rollup of 7 pull requests
Successful merges:
- rust-lang#98933 (Opaque types' generic params do not imply anything about their hidden type's lifetimes)
- rust-lang#101041 (translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2)
- rust-lang#101424 (Adjust and slightly generalize operator error suggestion)
- rust-lang#101496 (Allow lower_lifetime_binder receive a closure)
- rust-lang#101501 (Allow lint passes to be bound by `TyCtxt`)
- rust-lang#101515 (Recover from typo where == is used in place of =)
- rust-lang#101545 (Remove unnecessary `PartialOrd` and `Ord`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 2904060 into rust-lang:masterSep 8, 2022
@rustbotrustbot added this to the 1.65.0 milestone Sep 8, 2022
smoelius added a commit to trailofbits/dylint that referenced this pull request Oct 2, 2022
And add `boundary_toolchains` test
smoelius added a commit to trailofbits/dylint that referenced this pull request Oct 2, 2022
And add `boundary_toolchains` test
smoelius added a commit to trailofbits/dylint that referenced this pull request Oct 2, 2022
And add `boundary_toolchains` test
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 6, 2022
Allow lint passes to be bound by `TyCtxt`
This will allow storing things like `Ty<'tcx>` inside late lint passes. It's already possible to store various id types so they're already implicitly bound to a specific `TyCtxt`.
r? rust-lang/compiler
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 6, 2022
Rollup of 7 pull requests
Successful merges:
- rust-lang#98933 (Opaque types' generic params do not imply anything about their hidden type's lifetimes)
- rust-lang#101041 (translations(rustc_session): migrates rustc_session to use SessionDiagnostic - Pt. 2)
- rust-lang#101424 (Adjust and slightly generalize operator error suggestion)
- rust-lang#101496 (Allow lower_lifetime_binder receive a closure)
- rust-lang#101501 (Allow lint passes to be bound by `TyCtxt`)
- rust-lang#101515 (Recover from typo where == is used in place of =)
- rust-lang#101545 (Remove unnecessary `PartialOrd` and `Ord`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
yvt added a commit to yvt/servo that referenced this pull request Oct 16, 2022
yvt added a commit to yvt/servo that referenced this pull request Oct 16, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Jarcho@rustbot@davidtwco@bors@camsteffen@rust-highfive