Uh oh!
There was an error while loading. Please reload this page.
Stabilize nonzero_bits - #101514
Conversation
rustbot
commented
Sep 7, 2022
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
commented
Sep 7, 2022
(rust-highfive has picked a reviewer for you, use r? to override) |
joshtriplett
commented
Oct 3, 2022
This seems low-risk. These match the corresponding values on the non-nonzero integer types, and don't have any special considerations for nonzero-ness. @rfcbot merge |
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
commented
Oct 4, 2022
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
commented
Oct 14, 2022
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
thomcc
commented
Dec 3, 2022
This finished the FCP in favor a while ago, so it can be merged. @bors r+ |
bors
commented
Dec 3, 2022
bors
commented
Dec 4, 2022
bors
commented
Dec 4, 2022
☀️ Test successful - checks-actions |
rust-timer
commented
Dec 4, 2022
Finished benchmarking commit (9e77211): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Closes#94881, implemented by #93292.
This change stabilizes the associated
BITSconstant forNonZero{U,I}{8,16,32,64,128,size}integers, e.g.: