Shrink `ast::Expr` harder by nnethercote · Pull Request #101562 · rust-lang/rust

nnethercote · 2022-09-08T07:32:36Z

r? @ghost

rustbot · 2022-09-08T07:32:40Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

nnethercote · 2022-09-08T07:33:01Z

@bors try @rust-timer queue

rust-timer · 2022-09-08T07:33:02Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-09-08T07:33:10Z

⌛ Trying commit 55618ea7ce3e6a75b529e9570b37f77c777ed011 with merge 29c78f7bb22a7e545bae5ae196766f078fe7c1ac...

bors · 2022-09-08T09:23:32Z

☀️ Try build successful - checks-actions
Build commit: 29c78f7bb22a7e545bae5ae196766f078fe7c1ac (29c78f7bb22a7e545bae5ae196766f078fe7c1ac)

rust-timer · 2022-09-08T09:23:33Z

Queued 29c78f7bb22a7e545bae5ae196766f078fe7c1ac with parent 4af35b8, future comparison URL.

rust-timer · 2022-09-08T10:40:45Z

Finished benchmarking commit (29c78f7bb22a7e545bae5ae196766f078fe7c1ac): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.2%, 0.4%]	7
Improvements ✅ (primary)	-0.8%	[-1.3%, -0.4%]	5
Improvements ✅ (secondary)	-1.4%	[-3.8%, -0.3%]	32
All ❌✅ (primary)	-0.8%	[-1.3%, -0.4%]	5

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.7%	[2.6%, 4.8%]	5
Improvements ✅ (primary)	-1.4%	[-4.4%, -0.8%]	21
Improvements ✅ (secondary)	-3.6%	[-5.0%, -0.9%]	12
All ❌✅ (primary)	-1.4%	[-4.4%, -0.8%]	21

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[0.4%, 2.8%]	2
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-4.0%	[-6.8%, -2.0%]	21
All ❌✅ (primary)	-2.6%	[-2.6%, -2.6%]	1

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

nnethercote · 2022-09-08T11:15:11Z

r? @petrochenkov

nnethercote · 2022-09-08T11:19:09Z

Lots of nice performance wins here across all the metrics, hooray.

nnethercote · 2022-09-13T00:58:42Z

I fixed the conflicts.

nnethercote · 2022-09-13T23:11:17Z

@petrochenkov: I have rebased again, should be ready for review.

nnethercote · 2022-11-17T08:30:15Z

The cycles, wall-time, max-rss, and cache-misses results here are pretty good.

r? @petrochenkov

rustbot · 2022-11-17T08:30:17Z

Could not assign reviewer from: petrochenkov.
User(s) petrochenkov are either the PR author or are already assigned, and there are no other candidates.
Use r? to specify someone else to assign.

petrochenkov · 2022-11-17T22:51:56Z

@bors r+

bors · 2022-11-17T22:51:57Z

📌 Commit 67d5cc0 has been approved by petrochenkov

It is now in the queue for this repository.

bors · 2022-11-18T05:53:43Z

⌛ Testing commit 67d5cc0 with merge f6dc382af3e850df6eee3714780066c6d22fdc08...

bors · 2022-11-18T06:54:31Z

💔 Test failed - checks-actions

rust-log-analyzer · 2022-11-18T07:41:36Z

The job i686-mingw-1 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

test str::utf8_char_counts ... ok
failures:
---- rc::rc_from_vec_opt stdout ----
thread 'rc::rc_from_vec_opt' panicked at 'assertion failed: `(left == right)`
left: `-169216`,
right: `8`: Vector allocation not reused', library\alloc\tests\rc.rs:217:9
failures:
rc::rc_from_vec_opt
test result: FAILED. 652 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.29s
error: test failed, to rerun pass `-p alloc --test collectionstests`
Build completed unsuccessfully in 0:51:30
make: *** [Makefile:83: ci-mingw-subset-1] Error 1

petrochenkov · 2022-11-18T08:29:35Z

The error seems unrelated and spurious, but let's check again.
@bors retry

matthiaskrgr · 2022-11-18T08:47:52Z

cc #104563 :(

bors · 2022-11-18T16:56:15Z

⌛ Testing commit 67d5cc0 with merge 70fe5f0...

bors · 2022-11-18T20:26:52Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 70fe5f0 to master...

rust-timer · 2022-11-18T21:46:05Z

Finished benchmarking commit (70fe5f0): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 0.8%]	10
Regressions ❌ (secondary)	0.4%	[0.1%, 0.7%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.6%, -0.2%]	13
All ❌✅ (primary)	0.4%	[0.2%, 0.8%]	10

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.0%	[2.4%, 8.2%]	8
Improvements ✅ (primary)	-1.2%	[-2.3%, -0.8%]	13
Improvements ✅ (secondary)	-3.3%	[-4.5%, -1.5%]	13
All ❌✅ (primary)	-1.2%	[-2.3%, -0.8%]	13

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.3%	[-2.3%, -0.6%]	20
Improvements ✅ (secondary)	-3.3%	[-7.1%, -1.7%]	48
All ❌✅ (primary)	-1.3%	[-2.3%, -0.6%]	20

nnethercote · 2022-11-19T07:05:16Z

Instruction count results are mixed. But the real results are for cycles and wall-time, which show lots of improvements.

@rustbot label: +perf-regression-triaged

…r=petrochenkov Shrink `ast::Expr` harder r? `@ghost`

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 8, 2022

nnethercote marked this pull request as draft September 8, 2022 07:32

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 8, 2022

fbstj reviewed Sep 8, 2022
View reviewed changes

Comment threadcompiler/rustc_ast/src/attr/mod.rs Outdated

This comment has been minimized.
Sign in to view

rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 8, 2022

nnethercote marked this pull request as ready for review September 8, 2022 11:14

nnethercote force-pushed the shrink-ast-Expr-harder branch from 55618ea to 1d91c05Compare September 8, 2022 11:14

rust-highfive assigned petrochenkov Sep 8, 2022

This was referenced Sep 8, 2022
Remove token::Lit from ast::Lit. #101528
Closed
Remove the span from ast::Lit. #101516
Closed

This comment was marked as resolved.
Sign in to view

nnethercote force-pushed the shrink-ast-Expr-harder branch from 1d91c05 to 1dbc69eCompare September 13, 2022 00:57

This comment was marked as resolved.
Sign in to view

nnethercote force-pushed the shrink-ast-Expr-harder branch from 1dbc69e to 3dc22c4Compare September 13, 2022 23:10

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 18, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 18, 2022

bors merged commit 70fe5f0 into rust-lang:masterNov 18, 2022

rustbot added this to the 1.67.0 milestone Nov 18, 2022

bors mentioned this pull request Nov 18, 2022
Keep track of the start of the argument block of a closure #104199
Merged

nnethercote deleted the shrink-ast-Expr-harder branch November 18, 2022 21:17

This was referenced Nov 18, 2022
WIP: Thread GeneratorKind through to symbol mangling #104333
Closed
rustc_ast: remove ref patterns #104500
Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 19, 2022

flip1995 pushed a commit to flip1995/rust that referenced this pull request Nov 21, 2022
Auto merge ofrust-lang#101562- nnethercote:shrink-ast-Expr-harder, …
bc01b2e
…r=petrochenkov Shrink `ast::Expr` harder r? `@ghost`

Uh oh!

Uh oh!

Conversation

nnethercote commented Sep 8, 2022

Uh oh!

rustbot commented Sep 8, 2022

Uh oh!

nnethercote commented Sep 8, 2022

Uh oh!

rust-timer commented Sep 8, 2022

Uh oh!

bors commented Sep 8, 2022

Uh oh!

Uh oh!

bors commented Sep 8, 2022

Uh oh!

rust-timer commented Sep 8, 2022

Uh oh!

This comment has been minimized.

rust-timer commented Sep 8, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

nnethercote commented Sep 8, 2022

Uh oh!

nnethercote commented Sep 8, 2022

Uh oh!

This comment was marked as resolved.

nnethercote commented Sep 13, 2022

Uh oh!

This comment was marked as resolved.

nnethercote commented Sep 13, 2022

Uh oh!

nnethercote commented Nov 17, 2022

Uh oh!

rustbot commented Nov 17, 2022

Uh oh!

petrochenkov commented Nov 17, 2022

Uh oh!

bors commented Nov 17, 2022

Uh oh!

bors commented Nov 18, 2022

Uh oh!

bors commented Nov 18, 2022

Uh oh!

rust-log-analyzer commented Nov 18, 2022

Uh oh!

petrochenkov commented Nov 18, 2022

Uh oh!

matthiaskrgr commented Nov 18, 2022

Uh oh!

bors commented Nov 18, 2022

Uh oh!

bors commented Nov 18, 2022

Uh oh!

rust-timer commented Nov 18, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

nnethercote commented Nov 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants