Skip to content

Allow generators to impl Clone/Copy - #101673

Merged
bors merged 14 commits into
rust-lang:masterfrom
crlf0710:generator_clone
Sep 11, 2022
Merged

Allow generators to impl Clone/Copy#101673
bors merged 14 commits into
rust-lang:masterfrom
crlf0710:generator_clone

Conversation

@crlf0710

@crlf0710crlf0710 commented Sep 11, 2022

Copy link
Copy Markdown
Member

Revives #95137. It's a pity that the original pr didn't land because the implementation is almost complete! All credits goes to @canndrew, and i just resolved the merge conflicts and updated the feature gate version number.

r? @oli-obk

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 11, 2022
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2022
@crlf0710

Copy link
Copy Markdown
MemberAuthor

cc #95360

@crlf0710crlf0710 added A-coroutines Area: Coroutines F-coroutine_clone `#![feature(coroutine_clone)]` labels Sep 11, 2022
@rust-log-analyzer

This comment was marked as outdated.

@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 11, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 4e9bcb5 has been approved by oli-obk

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2022
@bors

bors commented Sep 11, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4e9bcb5 with merge 6f0c4a6...

@bors

bors commented Sep 11, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 6f0c4a6 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 11, 2022
@bors
bors merged commit 6f0c4a6 into rust-lang:masterSep 11, 2022
@rustbotrustbot added this to the 1.65.0 milestone Sep 11, 2022
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (6f0c4a6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1rangecount2
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
1.4%[0.9%, 2.2%]4
Improvements ✅
(primary)
-3.4%[-3.4%, -3.4%]1
Improvements ✅
(secondary)
-1.1%[-1.2%, -0.8%]4
All ❌✅ (primary)-3.4%[-3.4%, -3.4%]1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1rangecount2
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-6.9%[-6.9%, -6.9%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-6.9%[-6.9%, -6.9%]1

Footnotes

  1. the arithmetic mean of the percent change2

  2. number of relevant changes2

@canndrew

Copy link
Copy Markdown
Contributor

Ah, thanks tons @crlf0710 for picking this back up. I've been hella busy lately and let if fall by the wayside. Glad to see it made it in :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-coroutinesArea: CoroutinesF-coroutine_clone`#![feature(coroutine_clone)]`merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@crlf0710@rustbot@rust-log-analyzer@oli-obk@bors@rust-timer@canndrew@rust-highfive