Skip to content

A SubstitutionPart is not considered a deletion if it replaces nothing with nothing - #101700

Merged
bors merged 3 commits into
rust-lang:masterfrom
compiler-errors:deletion-span
Sep 13, 2022
Merged

A SubstitutionPart is not considered a deletion if it replaces nothing with nothing#101700
bors merged 3 commits into
rust-lang:masterfrom
compiler-errors:deletion-span

Conversation

@compiler-errors

@compiler-errorscompiler-errors commented Sep 11, 2022

Copy link
Copy Markdown
Contributor

Fixes#101689

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 11, 2022
@rust-highfive

rust-highfive commented Sep 11, 2022

Copy link
Copy Markdown
Contributor

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2022
compiler-errors
compiler-errors commented Sep 11, 2022
View reviewed changes
Comment threadsrc/test/ui/rust-2021/reserved-prefixes.stderr
@lcnr

lcnr commented Sep 12, 2022

Copy link
Copy Markdown
Contributor

r? compiler

@rust-highfiverust-highfive assigned davidtwco and unassigned lcnrSep 12, 2022
@davidtwco

davidtwco commented Sep 12, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 3bf33c3 has been approved by davidtwco

It is now in the queue for this repository.

@bors

bors commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 12, 2022
@GuillaumeGomez
Rollup merge ofrust-lang#101700- compiler-errors:deletion-span, r=d…
091e699
…avidtwco
A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing
Fixesrust-lang#101689
@GuillaumeGomezGuillaumeGomez mentioned this pull request Sep 12, 2022
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 12, 2022
@GuillaumeGomez
Rollup merge ofrust-lang#101700- compiler-errors:deletion-span, r=d…
8bb913d
…avidtwco
A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing
Fixesrust-lang#101689
@GuillaumeGomezGuillaumeGomez mentioned this pull request Sep 12, 2022
Closed
@compiler-errors

compiler-errors commented Sep 12, 2022

Copy link
Copy Markdown
ContributorAuthor

@bors r- (#101733 (comment))

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 12, 2022
@compiler-errorscompiler-errors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2022
@davidtwco

davidtwco commented Sep 13, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 13, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit cd962e6 has been approved by davidtwco

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Sep 13, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 13, 2022
@Dylan-DPC
Rollup merge ofrust-lang#101700- compiler-errors:deletion-span, r=d…
5e0f6bb
…avidtwco
A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing
Fixesrust-lang#101689
@Dylan-DPCDylan-DPC mentioned this pull request Sep 13, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 13, 2022
@bors
Auto merge ofrust-lang#101757- Dylan-DPC:rollup-wkt6oe9, r=Dylan-DPC
5338f5f
Rollup of 5 pull requests
Successful merges:
- rust-lang#101602 (Streamline `AttrAnnotatedTokenStream`)
- rust-lang#101690 (Avoid `Iterator::last`)
- rust-lang#101700 (A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing)
- rust-lang#101745 (Fix typo in concat_bytes documentation)
- rust-lang#101748 (rustdoc: remove redundant CSS `#source-sidebar, #sidebar-toggle`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit adcd1fb into rust-lang:masterSep 13, 2022
@rustbotrustbot added this to the 1.65.0 milestone Sep 13, 2022
@compiler-errors
compiler-errors deleted the deletion-span branch November 2, 2022 02:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwcodavidtwcodavidtwco approved these changes

Assignees

@davidtwcodavidtwco

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

Improve and make missing dyn help suggestion more uniform

6 participants

@compiler-errors@rust-highfive@lcnr@davidtwco@bors@rustbot