Uh oh!
There was an error while loading. Please reload this page.
Extend list of targets that support dyanmic linking for llvm tools - #101781
Merged
Conversation
rust-highfive
commented
Sep 13, 2022
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jyn514 (or someone else) soon. Please see the contribution instructions for more information. |
jyn514
suggested changes
Sep 14, 2022
Uh oh!
There was an error while loading. Please reload this page.
chriswailesforce-pushed
the
dynamic-llvm-on-musl
branch
2 times, most recently
from
September 14, 2022 20:14
fd5116c to
23abd10Comparejyn514
reviewed
Sep 14, 2022
Uh oh!
There was an error while loading. Please reload this page.
chriswailesforce-pushed
the
dynamic-llvm-on-musl
branch
2 times, most recently
from
September 14, 2022 22:44
772c094 to
76c863fComparechriswailes
commented
Sep 14, 2022
ContributorAuthor
@rustbot ready |
jyn514
commented
Sep 14, 2022
Member
Looks like this is working great :) thanks for testing it! If you can go ahead and revert the changes to |
This commit removes an allow-list for the dynamic linking of the LLVM tools and instead relies on the builder's linking preference only.
chriswailesforce-pushed
the
dynamic-llvm-on-musl
branch
from
September 16, 2022 20:10
76c863f to
9995029Comparejyn514
commented
Sep 16, 2022
Member
@bors r+ |
bors
commented
Sep 16, 2022
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 17, 2022
…r=jyn514 Extend list of targets that support dyanmic linking for llvm tools This commit adds `linux-musl` to the list of targets that support dynamic linking for the LLVM tools.
This was referenced Sep 17, 2022
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 17, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#101672 (array docs - advertise how to get array from slice) - rust-lang#101781 (Extend list of targets that support dyanmic linking for llvm tools) - rust-lang#101783 (Improve handing of env vars during bootstrap process) - rust-lang#101801 (add note for `layout_of` when query depth overflows) - rust-lang#101824 (rustdoc: add test cases for turning ``[Vec<T>]`` into ``[`Vec<T>`]``) - rust-lang#101861 (Update stdarch) - rust-lang#101873 (Allow building `rust-analyzer-proc-macro-srv` as a standalone tool) - rust-lang#101918 (rustdoc: clean up CSS for All Items and All Crates lists) - rust-lang#101934 (Continue migration of CSS themes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds
linux-muslto the list of targets that support dynamic linking for the LLVM tools.