Uh oh!
There was an error while loading. Please reload this page.
Tidy will not check coding style in bootstrap/target - #101786
Merged
Merged
Conversation
rust-highfive
commented
Sep 14, 2022
Contributor
r? @jyn514 (rust-highfive has picked a reviewer for you, use r? to override) |
jyn514
reviewed
Sep 14, 2022
jyn514
left a comment
Member
There was a problem hiding this comment.
This seems good :) can you also add it to .gitignore at the top level?
Uh oh!
There was an error while loading. Please reload this page.
chenyukangforce-pushed
the
fix-tidy-for-bootstrap
branch
from
September 14, 2022 06:45
32d6b2e to
31d5348Comparechenyukang
commented
Sep 14, 2022
MemberAuthor
It's already in .gitignore. |
jyn514
commented
Sep 14, 2022
Member
@bors r+ rollup At some point we should sync these ignored files with .gitignore, but that shouldn't block your PR. |
bors
commented
Sep 14, 2022
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#100415 (Add BE8 support) - rust-lang#101559 (Adding "backtrace off" option for fuchsia targets) - rust-lang#101740 (Adding ignore-fuchsia arg to non-applicable compiler ui tests) - rust-lang#101778 (rustdoc: clean up DOM by removing `.dockblock-short p`) - rust-lang#101786 (Tidy will not check coding style in bootstrap/target) - rust-lang#101810 (Constify `PartialEq` for `Ordering`) - rust-lang#101812 (rustdoc: clean up CSS `#titles` using flexbox) - rust-lang#101820 (rustdoc: remove no-op rule `a { background: transparent }`) - rust-lang#101828 (Add test for rust-lang#101743) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bootstrap/targetmay contains the files generated byrust-analysis, which we won't want to be checked.