Skip to content

Do not suggest a placeholder to const and static without a type - #101790

Merged
bors merged 1 commit into
rust-lang:masterfrom
TaKO8Ki:do-not-suggest-placeholder-to-const-and-static-without-type
Sep 17, 2022
Merged

Do not suggest a placeholder to const and static without a type#101790
bors merged 1 commit into
rust-lang:masterfrom
TaKO8Ki:do-not-suggest-placeholder-to-const-and-static-without-type

Conversation

@TaKO8Ki

@TaKO8KiTaKO8Ki commented Sep 14, 2022

Copy link
Copy Markdown
Member

Fixes#101755

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 14, 2022
@rust-highfive

rust-highfive commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2022
compiler-errors
compiler-errors reviewed Sep 15, 2022
View reviewed changes

@compiler-errorscompiler-errors left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

Comment threadcompiler/rustc_typeck/src/collect.rs Outdated
@compiler-errorscompiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2022
@TaKO8Ki
TaKO8Kiforce-pushed the do-not-suggest-placeholder-to-const-and-static-without-type branch from 33af495 to 527292aCompareSeptember 16, 2022 02:26
@TaKO8Ki

TaKO8Ki commented Sep 16, 2022

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 16, 2022
@compiler-errors

compiler-errors commented Sep 17, 2022

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 17, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 527292a has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Sep 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2022
@bors
Auto merge ofrust-lang#101938- Dylan-DPC:rollup-6vlohhs, r=Dylan-DPC
672831a
Rollup of 6 pull requests
Successful merges:
- rust-lang#93628 (Stabilize `let else`)
- rust-lang#98441 (Implement simd_as for pointers)
- rust-lang#101790 (Do not suggest a placeholder to const and static without a type)
- rust-lang#101807 (Disallow defaults on type GATs)
- rust-lang#101915 (doc: fix redirected link in `/index.html`)
- rust-lang#101931 (doc: Fix a typo in `Rc::make_mut` docstring)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 4c64c14 into rust-lang:masterSep 17, 2022
@rustbotrustbot added this to the 1.65.0 milestone Sep 17, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compiler-errorscompiler-errorsAwaiting requested review from compiler-errors

Assignees

@compiler-errorscompiler-errors

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

placeholder _ is referred when there is a trait const with no type whatsoever.

5 participants

@TaKO8Ki@rust-highfive@compiler-errors@bors@rustbot