Skip to content

Constify impl Fn* &(mut) Fn* - #101802

Merged
bors merged 2 commits into
rust-lang:masterfrom
onestacked:const_fn_trait_ref_impls
Sep 16, 2022
Merged

Constify impl Fn* &(mut) Fn*#101802
bors merged 2 commits into
rust-lang:masterfrom
onestacked:const_fn_trait_ref_impls

Conversation

@onestacked

@onestackedonestacked commented Sep 14, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Tracking Issue: 101803

Feature gate: #![feature(const_fn_trait_ref_impls)]

This feature allows using references to Fn* Items as Fn* Items themself in a const context.

@fee1-dead

fee1-dead commented Sep 14, 2022

Copy link
Copy Markdown
Member

Please open a tracking issue, and then I will approve. Thank you for this PR!

r? @fee1-dead

@onestackedonestacked mentioned this pull request Sep 14, 2022
Closed
3 tasks
@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 14, 2022
@rustbot

rustbot commented Sep 14, 2022

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@onestacked

onestacked commented Sep 14, 2022

Copy link
Copy Markdown
ContributorAuthor

Added Tracking issue.

Since this constifies Public API.
@rustbot label +T-libs-api -T-libs

@rustbotrustbot added T-libs-api [DEPRECATED; DO NOT USE] and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 14, 2022
@fee1-dead

fee1-dead commented Sep 14, 2022

Copy link
Copy Markdown
Member

@bors r+ rollup

@JohnTitor

This comment was marked as resolved.

Sign in to view
@JohnTitorJohnTitor reopened this Sep 15, 2022
@JohnTitor

This comment was marked as resolved.

Sign in to view
@bors

bors commented Sep 15, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 478c471 has been approved by fee1-dead

It is now in the queue for this repository.

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 15, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 15, 2022
@Dylan-DPC
Rollup merge ofrust-lang#101802- chriss0612:const_fn_trait_ref_impl…
6e23b26
…s, r=fee1-dead
Constify impl Fn* &(mut) Fn*
Tracking Issue: [101803](rust-lang#101803)
Feature gate: `#![feature(const_fn_trait_ref_impls)]`
This feature allows using references to Fn* Items as Fn* Items themself in a const context.
@Dylan-DPCDylan-DPC mentioned this pull request Sep 15, 2022
Closed
@Dylan-DPCDylan-DPC mentioned this pull request Sep 15, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 15, 2022
@Dylan-DPC
Rollup merge ofrust-lang#101802- chriss0612:const_fn_trait_ref_impl…
6ef180e
…s, r=fee1-dead
Constify impl Fn* &(mut) Fn*
Tracking Issue: [101803](rust-lang#101803)
Feature gate: `#![feature(const_fn_trait_ref_impls)]`
This feature allows using references to Fn* Items as Fn* Items themself in a const context.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 15, 2022
@Dylan-DPC
Rollup merge ofrust-lang#101802- chriss0612:const_fn_trait_ref_impl…
1965a3c
…s, r=fee1-dead
Constify impl Fn* &(mut) Fn*
Tracking Issue: [101803](rust-lang#101803)
Feature gate: `#![feature(const_fn_trait_ref_impls)]`
This feature allows using references to Fn* Items as Fn* Items themself in a const context.
@Dylan-DPCDylan-DPC mentioned this pull request Sep 15, 2022
Closed
@Dylan-DPCDylan-DPC mentioned this pull request Sep 16, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2022
@bors
Auto merge ofrust-lang#101882- Dylan-DPC:rollup-9lxwuwj, r=Dylan-DPC
22f6aec
Rollup of 7 pull requests
Successful merges:
- rust-lang#101722 (Rustdoc-Json: Fix Type docs.)
- rust-lang#101738 (Fix `#[link kind="raw-dylib"]` to respect `#[link_name]`)
- rust-lang#101753 (Prefer explict closure sig types over expected ones)
- rust-lang#101787 (cache `collect_trait_impl_trait_tys`)
- rust-lang#101802 (Constify impl Fn* &(mut) Fn*)
- rust-lang#101809 (Replace `check_missing_items.py` with `jsondoclint`)
- rust-lang#101864 (rustdoc: remove no-op CSS `h1-4 { color: --main-color }`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit cfef659 into rust-lang:masterSep 16, 2022
@rustbotrustbot added this to the 1.65.0 milestone Sep 16, 2022
@onestacked
onestacked deleted the const_fn_trait_ref_impls branch September 16, 2022 10:07
@onestackedonestacked mentioned this pull request Sep 22, 2022
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fee1-deadfee1-dead

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

5 participants

@onestacked@fee1-dead@rustbot@JohnTitor@bors