Uh oh!
There was an error while loading. Please reload this page.
rustdoc: remove bad CSS font-weight on .impl, .method, etc - #102442
Merged
Conversation
rust-highfive
commented
Sep 28, 2022
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
commented
Sep 28, 2022
Collaborator
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
notriddleforce-pushed
the
notriddle/header-weight
branch
from
September 28, 2022 22:19
036fe33 to
719c88aCompareGuillaumeGomez
approved these changes
Sep 28, 2022
GuillaumeGomez
commented
Sep 28, 2022
Member
Thanks! r=me once CI pass. |
notriddleforce-pushed
the
notriddle/header-weight
branch
2 times, most recently
from
September 28, 2022 23:17
4a817f4 to
3f21f07CompareThis line was added in c494a06, because at the time, the headers had these classes on them. Now, the headers are children of the `<section>` with the class on it. This commit also adds a test case, to make sure the srclink font weight does not regress again.
notriddle
commented
Sep 28, 2022
ContributorAuthor
@bors r=GuillaumeGomez rollup |
bors
commented
Sep 28, 2022
Collaborator
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Sep 29, 2022
… r=GuillaumeGomez rustdoc: remove bad CSS font-weight on `.impl`, `.method`, etc This line was added in c494a06, because at the time, the headers had these classes on them. Now, the headers are children of the `<section>` with the class on it. This commit also adds a test case, to make sure the srclink font weight does not regress again.
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Sep 29, 2022
… r=GuillaumeGomez rustdoc: remove bad CSS font-weight on `.impl`, `.method`, etc This line was added in c494a06, because at the time, the headers had these classes on them. Now, the headers are children of the `<section>` with the class on it. This commit also adds a test case, to make sure the srclink font weight does not regress again.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 29, 2022
… r=GuillaumeGomez rustdoc: remove bad CSS font-weight on `.impl`, `.method`, etc This line was added in c494a06, because at the time, the headers had these classes on them. Now, the headers are children of the `<section>` with the class on it. This commit also adds a test case, to make sure the srclink font weight does not regress again.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 29, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#102214 (Fix span of byte-escaped left format args brace) - rust-lang#102426 (Don't export `__wasm_init_memory` on WebAssembly.) - rust-lang#102437 (rustdoc: cut margin-top from first header in docblock) - rust-lang#102442 (rustdoc: remove bad CSS font-weight on `.impl`, `.method`, etc) - rust-lang#102447 (rustdoc: add method spacing to trait methods) - rust-lang#102468 (tidy: make rustc dependency error less confusing) - rust-lang#102476 (Split out the error reporting logic into a separate function) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line was added in c494a06, because at the time, the headers had these classes on them. Now, the headers are children of the
<section>with the class on it.This commit also adds a test case, to make sure the srclink font weight does not regress again.