Skip to content

Split collect.rs - #102461

Merged
bors merged 2 commits into
rust-lang:masterfrom
oli-obk:split_collect_rs
Sep 29, 2022
Merged

Split collect.rs#102461
bors merged 2 commits into
rust-lang:masterfrom
oli-obk:split_collect_rs

Conversation

@oli-obk

Copy link
Copy Markdown
Contributor

This file was way too big (adding a few lines of code caused tidy to trigger)

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 29, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2022
@lcnr

lcnr commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

r? @lcnr

@bors r+ rollup=never p=5

@bors

bors commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit f22f149 has been approved by lcnr

It is now in the queue for this repository.

@rust-highfiverust-highfive assigned lcnr and unassigned jackh726Sep 29, 2022
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2022
@bors

bors commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f22f149 with merge c5bbf36...

@bors

bors commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing c5bbf36 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 29, 2022
@bors
bors merged commit c5bbf36 into rust-lang:masterSep 29, 2022
@rustbotrustbot added this to the 1.66.0 milestone Sep 29, 2022
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (c5bbf36): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1rangecount2
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-1.3%[-1.6%, -1.1%]7
All ❌✅ (primary)--0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1rangecount2
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
4.3%[3.7%, 5.0%]2
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1rangecount2
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
2.3%[2.3%, 2.3%]1
Improvements ✅
(primary)
-5.8%[-5.8%, -5.8%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-5.8%[-5.8%, -5.8%]1

Footnotes

  1. the arithmetic mean of the percent change23

  2. number of relevant changes23

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@oli-obk@rust-highfive@lcnr@bors@rust-timer@jackh726@rustbot