Rollup of 7 pull requests by Dylan-DPC · Pull Request #102471 · rust-lang/rust

Dylan-DPC · 2022-09-29T12:43:22Z

Successful merges:

Fix associated type bindings with anon const in GAT position #102336 (Fix associated type bindings with anon const in GAT position)
Add negation methods for signed non-zero integers. #102342 (Add negation methods for signed non-zero integers.)
Don't export __heap_base and __data_end on wasm32-wasi. #102385 (Don't export __heap_base and __data_end on wasm32-wasi.)
Improve example of Iterator::reduce #102435 (Improve example of Iterator::reduce)
rustdoc: clean up "normalize.css 8" input override CSS #102436 (rustdoc: clean up "normalize.css 8" input override CSS)
fix minor ungrammatical sentence #102452 (fix minor ungrammatical sentence)
Use let-chaining in WhileTrue::check_expr. #102455 (Use let-chaining in WhileTrue::check_expr.)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

`__heap_base` and `__data_end` are exported for use by wasm-bindgen, which uses the wasm32-unknown-unknown target. On wasm32-wasi, as a step toward implementing the Canonical ABI, and as an aid to building speicalized WASI API polyfill wrappers, don't export `__heap_base` and `__data_end` on wasm32-wasi.

These rules were copied from normalize.css 3, and are mostly redundant. * `optgroup` isn't used in rustdoc at all * `textarea` is only used for the "copy" button, so it's not visible * The remaining buttons and inputs mostly have styles set anyway. * We should never be setting `color` without also setting the background to something. Otherwise, you get white-on-gray text. That seems to be [the reason] why `normalize.css` changed this. [the reason]: necolas/normalize.css#502

This has been bugging me for a while.

…ckh726 Fix associated type bindings with anon const in GAT position The first commit formats `type_of.rs`, which is really hard to maintain since it uses a bunch of features like `let`-chains and `if let` match arm bindings. Best if you just review the second two diffs. Fixesrust-lang#102333

…tmcm Add negation methods for signed non-zero integers. Performing negation with defined wrapping semantics (such as `wrapping_neg()`) on a non-zero integer currently requires unpacking to a primitive and re-wrapping. Since negation of non-zero signed integers always produces a non-zero result, it is safe to implement the various `*_neg()` methods for `NonZeroI{N}`. I'm not sure what to do about the `#[unstable(..., issue = "none")]` here -- should I file a tracking issue, or is that handled by the Rust dev team? ACP: rust-lang/libs-team#105

…port-heap-base, r=davidtwco Don't export `__heap_base` and `__data_end` on wasm32-wasi. `__heap_base` and `__data_end` are exported for use by wasm-bindgen, which uses the wasm32-unknown-unknown target. On wasm32-wasi, as a step toward implementing the Canonical ABI, and as an aid to building speicalized WASI API polyfill wrappers, don't export `__heap_base` and `__data_end` on wasm32-wasi.

…duce-example, r=thomcc,vacuus Improve example of Iterator::reduce Fixesrust-lang#81819. I took your example `@bstrie` from rust-lang#81819 and applied it here. r? `@thomcc`

…, r=GuillaumeGomez rustdoc: clean up "normalize.css 8" input override CSS These rules were copied from normalize.css 3, and are mostly redundant. * `optgroup` isn't used in rustdoc at all * `textarea` is only used for the "copy" button, so it's not visible * The remaining buttons and inputs mostly have styles set anyway. * We should never be setting `color` without also setting the background to something. Otherwise, you get white-on-gray text. That seems to be [the reason] why `normalize.css` changed this. [the reason]: necolas/normalize.css#502

fix minor ungrammatical sentence This fixes an innocuous ungrammatical sentence in example code in the `TryFrom` documentation.

…r=lqd Use let-chaining in `WhileTrue::check_expr`. This has been bugging me for a while. r? `@lqd`

Dylan-DPC · 2022-09-29T12:43:46Z

@bors r+ rollup=never p=5

bors · 2022-09-29T12:43:48Z

📌 Commit f4e7094 has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2022-09-29T13:27:31Z

⌛ Testing commit f4e7094 with merge 65445a5...

bors · 2022-09-29T16:24:26Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 65445a5 to master...

bors · 2022-09-29T16:24:26Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 65445a5 to master...

rust-timer · 2022-09-29T16:24:49Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha

previous master: 65445a571c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-09-29T16:26:35Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#102455	6ad22c7b351a4e387511a328ca1d6f7c1335ece4
#102452	6ef319b9273b34ba18a2846542931a966570aad6
#102436	b16a8e6620e00ddeef2c76182db32c3647863634
#102435	cebbdc283e4e8d27bc06ab765e8cc22fae0ec57d
#102385	2a8dd6119072ec0405ce83b443114827f5a4ae80
#102342	550e4dc585586bc4a20d0d964637578bb15f4d0d
#102336	74068c35bd27ec44a6ee9ef60cc451764b3fce00

previous master: c5bbf36a31

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-09-29T17:49:09Z

Finished benchmarking commit (65445a5): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	3.0%	[2.4%, 3.5%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.1%	[-4.1%, -4.1%]	1
All ❌✅ (primary)	2.2%	[2.2%, 2.2%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.4%	[2.4%, 2.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	2.4%	[2.4%, 2.4%]	1

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

jmillikinand others added 18 commits September 27, 2022 13:15

Add negation methods for signed non-zero integers.
259bbfb

Format type_of
cca4828

Make type_of work correctly for const arg bindings
05267b5

Support bindings with anon consts in generics
92561f4

nonzero_negation_ops: Set issue = "102443".
cdae82c

nonzero_negation_ops: inline(always) -> inline.
ceb53a3

Improve example of Iterator::reduce
49b25d3

Use let-chaining in WhileTrue::check_expr.
269ff92
This has been bugging me for a while.

fix minor ungrammatical sentence
06624e8

Rollup merge ofrust-lang#102435- GuillaumeGomez:improve-iterator-re…
b6d1c15
…duce-example, r=thomcc,vacuus Improve example of Iterator::reduce Fixesrust-lang#81819. I took your example `@bstrie` from rust-lang#81819 and applied it here. r? `@thomcc`

Rollup merge ofrust-lang#102452- granolocks:grammar-tweak, r=thomcc
34f02c3
fix minor ungrammatical sentence This fixes an innocuous ungrammatical sentence in example code in the `TryFrom` documentation.

Rollup merge ofrust-lang#102455- nnethercote:WhileTrue-check_expr, …
f4e7094
…r=lqd Use let-chaining in `WhileTrue::check_expr`. This has been bugging me for a while. r? `@lqd`

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 29, 2022

Dylan-DPC mentioned this pull request Sep 29, 2022
Rollup of 4 pull requests #102457
Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 29, 2022

bors merged commit 65445a5 into rust-lang:masterSep 29, 2022

rustbot added this to the 1.66.0 milestone Sep 29, 2022

rylev mentioned this pull request Sep 30, 2022
Post Rollup Warnings rust-lang/triagebot#1657
Open

Navigation Menu

Uh oh!

Uh oh!

Rollup of 7 pull requests - #102471

Rollup of 7 pull requests#102471
bors merged 18 commits into
rust-lang:masterfrom
Dylan-DPC:rollup-ij3okjt

Dylan-DPC commented Sep 29, 2022

Uh oh!

Dylan-DPC commented Sep 29, 2022

Uh oh!

bors commented Sep 29, 2022

Uh oh!

bors commented Sep 29, 2022

Uh oh!

bors commented Sep 29, 2022

Uh oh!

bors commented Sep 29, 2022

Uh oh!

rust-timer commented Sep 29, 2022

Uh oh!

rust-timer commented Sep 29, 2022

Uh oh!

rust-timer commented Sep 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Uh oh!

Conversation

Dylan-DPC commented Sep 29, 2022

Uh oh!

Dylan-DPC commented Sep 29, 2022

Uh oh!

bors commented Sep 29, 2022

Uh oh!

bors commented Sep 29, 2022

Uh oh!

bors commented Sep 29, 2022

Uh oh!

bors commented Sep 29, 2022

Uh oh!

rust-timer commented Sep 29, 2022

Uh oh!

rust-timer commented Sep 29, 2022

Uh oh!

rust-timer commented Sep 29, 2022

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants