Uh oh!
There was an error while loading. Please reload this page.
make incoherent_auto_trait_objects a hard error - #102474
Conversation
lcnr
commented
Sep 29, 2022
@bors try |
bors
commented
Sep 29, 2022
⌛ Trying commit 96ae278 with merge 4d7187a26f9eb7e5000e28e28662298d34d2508f... |
bors
commented
Sep 29, 2022
☀️ Try build successful - checks-actions |
lcnr
commented
Sep 29, 2022
@craterbot check |
craterbot
commented
Sep 29, 2022
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
commented
Sep 29, 2022
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
commented
Sep 30, 2022
🎉 Experiment
|
lcnr
commented
Oct 3, 2022
ok that looks wrong 🤔 cc @rust-lang/infra is that an issue with crater? i would have expected the |
jyn514
commented
Oct 3, 2022
@lcnr the newly failed builds are marked "build OOM"; I don't know the details of this change but it seems plausible to me it could be taking extra memory. They're marked as "spurious regressions"; you can see the root regressions (due to compiler errors) under "root results". |
jyn514
commented
Oct 3, 2022
ah, and |
lcnr
commented
Oct 3, 2022
hmm, interesting that it doesn't fail as a root cause 🤔 only looked at the first 3 entries of "regressed: dependencies" which were all spurious '^^ should have maybe looked a bit further down 😁 |
lcnr
commented
Oct 3, 2022
intend to add the lint to future-breakage reports for now as there are >1000 regressions: #102635 |
…, r=jackh726 make `order_dependent_trait_objects` show up in future-breakage reports tried to change it to a hard error in rust-lang#102474 but breaking the more than 1000 dependents of `traitobject` doesn't feel great 😅 This lint has existed since more than 3 years now and the way this is currently implemented is buggy and will break with rust-lang#102472. imo we should upgrade it to also report for dependencies and maybe also backport this to beta. Then after maybe 2-3 stable versions I would like to finally convert this lint to a hard error.
…, r=jackh726 make `order_dependent_trait_objects` show up in future-breakage reports tried to change it to a hard error in rust-lang#102474 but breaking the more than 1000 dependents of `traitobject` doesn't feel great 😅 This lint has existed since more than 3 years now and the way this is currently implemented is buggy and will break with rust-lang#102472. imo we should upgrade it to also report for dependencies and maybe also backport this to beta. Then after maybe 2-3 stable versions I would like to finally convert this lint to a hard error.
needs a crater run, this lint exists since nearly 4 years now and the affected crate is not maintained anymore.
The current implementation for the lint will break with #102472, which is fixes caching for the trait system. Keeping this lint working with the current implementation will be non-trivial and imo not worth the cost.
closes#56484
r? types