Add diagnostic struct for const eval error in `rustc_middle` by pierwill · Pull Request #102486 · rust-lang/rust

pierwill · 2022-09-29T19:50:07Z

rustbot · 2022-09-29T19:50:10Z

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

rustbot · 2022-10-02T20:57:50Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

Some changes occurred in need_type_info.rs

cc @lcnr

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

A change occurred in the Ayu theme.

cc @Cldfire

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in const_evaluatable.rs

cc @lcnr

GuillaumeGomez · 2022-10-02T21:01:53Z

I think you failed a rebase.

davidtwco · 2022-10-03T09:45:46Z

Why has this changed?

I'm not sure :(

pierwill · 2022-10-03T17:29:28Z

I'm stilling getting strange ui test errors locally, but this passes in CI.

Co-authored-by: Michael Goulet <michael@errs.io>

compiler-errors · 2022-10-03T17:34:58Z

@pierwill are you rebased onto the latest master? maybe that's why.

pierwill · 2022-10-03T18:02:54Z

@pierwill are you rebased onto the latest master? maybe that's why.

I am. :(

compiler-errors · 2022-10-03T18:05:03Z

r? @compiler-errors @bors r+ rollup

bors · 2022-10-03T18:05:04Z

📌 Commit b9c0467 has been approved by compiler-errors

It is now in the queue for this repository.

…compiler-errors Add diagnostic struct for const eval error in `rustc_middle` Part of rust-lang#100717. r? `@ghost`

pierwill · 2022-10-03T18:29:59Z

@rustbot label -A-bootstrap -A-query-system

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#98218 (Document the conditional existence of `alloc::sync` and `alloc::task`.) - rust-lang#99216 (docs: be less harsh in wording for Vec::from_raw_parts) - rust-lang#99460 (docs: Improve AsRef / AsMut docs on blanket impls) - rust-lang#100470 (Tweak `FpCategory` example order.) - rust-lang#101040 (Fix `#[derive(Default)]` on a generic `#[default]` enum adding unnecessary `Default` bounds) - rust-lang#101308 (introduce `{char, u8}::is_ascii_octdigit`) - rust-lang#102486 (Add diagnostic struct for const eval error in `rustc_middle`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 29, 2022