Uh oh!
There was an error while loading. Please reload this page.
rustdoc: remove no-op source sidebar opacity - #102491
Merged
Merged
Conversation
These rules were added in dc2c972 to work with CSS transitions. They're otherwise redundant, since the `visibility` property already hides everything. https://github.com/rust-lang/rust/blob/dc2c9723343c985740be09919236a6e96c4e4433/src/librustdoc/html/static/css/rustdoc.css#L350-L354 The transition was remove with 237d625, but the now-redundant `opacity` property was not.
rustbot
commented
Sep 29, 2022
Collaborator
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
rust-highfive
commented
Sep 29, 2022
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. Please see the contribution instructions for more information. |
GuillaumeGomez
approved these changes
Sep 29, 2022
GuillaumeGomez
commented
Sep 29, 2022
Member
Thanks! @bors r+ rollup |
bors
commented
Sep 29, 2022
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 30, 2022
…y, r=GuillaumeGomez rustdoc: remove no-op source sidebar `opacity` These rules were added in dc2c972 to work with CSS transitions. They're otherwise redundant, since the `visibility` property already hides everything. https://github.com/rust-lang/rust/blob/dc2c9723343c985740be09919236a6e96c4e4433/src/librustdoc/html/static/css/rustdoc.css#L350-L354 The transition was remove with 237d625, but the now-redundant `opacity` property was not.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 30, 2022
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#101075 (Migrate rustc_codegen_gcc to SessionDiagnostics ) - rust-lang#102350 (Improve errors for incomplete functions in struct definitions) - rust-lang#102481 (rustdoc: remove unneeded CSS `.rust-example-rendered { position }`) - rust-lang#102491 (rustdoc: remove no-op source sidebar `opacity`) - rust-lang#102499 (Adjust the s390x data layout for LLVM 16) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These rules were added in dc2c972 to work with CSS transitions. They're otherwise redundant, since the
visibilityproperty already hides everything.rust/src/librustdoc/html/static/css/rustdoc.css
Lines 350 to 354 in dc2c972
The transition was remove with 237d625, but the now-redundant
opacityproperty was not.