Perf improvements for effective visibility calculating by Bryanskiy · Pull Request #103158 · rust-lang/rust

Bryanskiy · 2022-10-17T18:14:05Z

related to #102026
r? @petrochenkov

petrochenkov · 2022-10-18T10:37:06Z

If the update operation is a hotspot you need to get rid of all the helper methods it calls and reimplemented it from scratch as a single operation.

What I don't like right now:

Two nested loops over levels, the logic should go over the previous and parent effective visibilities once and do the minimal number of comparisons.
EffectiveVisibility::update is only called once from AccessLevels::update and can be inlined/removed.
Double search in the map self.get_effective_vis(id) + self.map.insert(id, ...), you could use self.map.entry(...) instead.

It may also be useful to go back to using Option<Visibility>es in EffectiveVisibility, in that case fully private visibilities (None) can be compared without is_at_least.
All of this needs benchmarking though.

Also, as I said in #102026 (comment) it's possible that update itself is not the main reason for the slowdown, it's possible that the reason is that we call it for items for which we shouldn't call it at all.
@rustbot author

Bryanskiy · 2022-10-19T15:17:10Z

@rustbot ready

Bryanskiy · 2022-10-23T12:13:39Z

@rustbot ready

petrochenkov · 2022-10-23T20:43:09Z

I cannot start a perf run until this PR is rebased.
@rustbot author

Bryanskiy · 2022-10-24T08:52:56Z

@rustbot ready

Bryanskiy · 2022-10-25T09:41:10Z

@rustbot ready

petrochenkov · 2022-10-25T09:49:15Z

r=me after squashing commits.
@rustbot author

Bryanskiy · 2022-10-25T12:16:38Z

@rustbot ready

petrochenkov · 2022-10-25T19:11:16Z

@bors r+

bors · 2022-10-25T19:11:18Z

📌 Commit a9447bb has been approved by petrochenkov

It is now in the queue for this repository.

bors · 2022-10-26T02:30:21Z

⌛ Testing commit a9447bb with merge a5406fe...

bors · 2022-10-26T05:17:32Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing a5406fe to master...

rust-timer · 2022-10-26T06:37:49Z

Finished benchmarking commit (a5406fe): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.5%, -0.3%]	6
Improvements ✅ (secondary)	-0.6%	[-2.0%, -0.2%]	22
All ❌✅ (primary)	-0.4%	[-0.5%, -0.3%]	6

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	-	-	0

the arithmetic mean of the percent change↩↩²
number of relevant changes↩↩²

Perf improvements for effective visibility calculating related to rust-lang#102026 r? `@petrochenkov`

rust-highfive assigned petrochenkov Oct 17, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 17, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2022

This comment has been minimized.
Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2022

Bryanskiy force-pushed the resolve_perf branch 2 times, most recently from 23f8a02 to da872f1Compare October 19, 2022 14:52

rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Oct 19, 2022

Bryanskiy force-pushed the resolve_perf branch from da872f1 to 13b17d3Compare October 19, 2022 14:57

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2022

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2022

Bryanskiy force-pushed the resolve_perf branch 2 times, most recently from d31d83c to f162be9Compare October 23, 2022 11:45

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 23, 2022

This comment was marked as resolved.
Sign in to view

petrochenkov reviewed Oct 23, 2022
View reviewed changes

Comment threadcompiler/rustc_resolve/src/access_levels.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2022

Bryanskiy force-pushed the resolve_perf branch from f162be9 to cc546edCompare October 24, 2022 08:46

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2022

petrochenkov changed the title ~~[WIP] perf improvements for effective visibility calculating~~Perf improvements for effective visibility calculatingOct 25, 2022

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2022

This comment has been minimized.
Sign in to view

Perf improvements for effective visibility calculating
a9447bb

Bryanskiy force-pushed the resolve_perf branch from 1ea7b44 to a9447bbCompare October 25, 2022 12:16

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 26, 2022

bors merged commit a5406fe into rust-lang:masterOct 26, 2022

rustbot added this to the 1.66.0 milestone Oct 26, 2022

This was referenced Oct 26, 2022
privacy: Rename "accessibility levels" to "effective visibilities" #102233
Merged
Rollup of 9 pull requests #103553
Closed

petrochenkov mentioned this pull request Oct 29, 2022
Populate effective visibilities in 'rustc_resolve' #102026
Merged

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
Auto merge ofrust-lang#103158- Bryanskiy:resolve_perf, r=petrochenkov
8c19823
Perf improvements for effective visibility calculating related to rust-lang#102026 r? `@petrochenkov`

Bryanskiy deleted the resolve_perf branch May 17, 2023 13:36

ghost approved these changes Oct 14, 2024
View reviewed changes

Uh oh!

Uh oh!

Conversation

Bryanskiy commented Oct 17, 2022

Uh oh!

This comment has been minimized.

petrochenkov commented Oct 18, 2022

Uh oh!

Bryanskiy commented Oct 19, 2022

Uh oh!

Bryanskiy commented Oct 23, 2022

Uh oh!

This comment was marked as resolved.

Uh oh!

petrochenkov commented Oct 23, 2022

Uh oh!

Bryanskiy commented Oct 24, 2022

Uh oh!

Bryanskiy commented Oct 25, 2022

Uh oh!

petrochenkov commented Oct 25, 2022

Uh oh!

This comment has been minimized.

Bryanskiy commented Oct 25, 2022

Uh oh!

petrochenkov commented Oct 25, 2022

Uh oh!

bors commented Oct 25, 2022

Uh oh!

bors commented Oct 26, 2022

Uh oh!

bors commented Oct 26, 2022

Uh oh!

rust-timer commented Oct 26, 2022

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants