') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); rustdoc: remove redundant CSS on `#copy-path` by notriddle · Pull Request #103161 · rust-lang/rust · GitHub
Skip to content

rustdoc: remove redundant CSS on #copy-path - #103161

Merged
bors merged 1 commit into
rust-lang:masterfrom
notriddle:notriddle/copy-path-settings-help-button
Oct 18, 2022
Merged

rustdoc: remove redundant CSS on #copy-path#103161
bors merged 1 commit into
rust-lang:masterfrom
notriddle:notriddle/copy-path-settings-help-button

Conversation

@notriddle

@notriddlenotriddle commented Oct 17, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

The border and background were removed in 5d004c1, but not all the CSS was.

@rust-highfive

rust-highfive commented Oct 17, 2022

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jsha (or someone else) soon.

Please see the contribution instructions for more information.

@rustbotrustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 17, 2022
@rustbot

rustbot commented Oct 17, 2022

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2022
@notriddle
rustdoc: remove redundant CSS on #copy-path
3aa3b8b
The border and background were removed in
5d004c1, but not all the CSS was.
@notriddle
notriddleforce-pushed the notriddle/copy-path-settings-help-button branch from 2fcf148 to 3aa3b8bCompareOctober 17, 2022 18:59
GuillaumeGomez
GuillaumeGomez reviewed Oct 17, 2022
View reviewed changes
Comment threadsrc/librustdoc/html/static/css/rustdoc.css
@GuillaumeGomez

GuillaumeGomez commented Oct 17, 2022

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@bors

bors commented Oct 17, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 3aa3b8b has been approved by GuillaumeGomez

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2022
@matthiaskrgrmatthiaskrgr mentioned this pull request Oct 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2022
@bors
Auto merge ofrust-lang#103165- matthiaskrgr:rollup-guw8oh6, r=matth…
194140b
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#103152 (Use named arguments to make GUI test more clear)
- rust-lang#103160 (rustdoc: factor JS mobile scroll lock into its own function)
- rust-lang#103161 (rustdoc: remove redundant CSS on `#copy-path`)
- rust-lang#103162 (rustdoc: remove redundant CSS `#crate-search { border-radius }`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1e7b6ec into rust-lang:masterOct 18, 2022
@rustbotrustbot added this to the 1.66.0 milestone Oct 18, 2022
@notriddle
notriddle deleted the notriddle/copy-path-settings-help-button branch October 18, 2022 17:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

Assignees

@jshajsha

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.66.0

Development

Successfully merging this pull request may close these issues.

6 participants

@notriddle@rust-highfive@rustbot@GuillaumeGomez@bors@jsha