Fix `src/test/run-make/issue-36710` on cross-compiled targets by emilyalbini · Pull Request #103179 · rust-lang/rust

emilyalbini · 2022-10-18T07:53:56Z

This PR fixes the src/test/run-make/issue-36710 test not working on cross-compiled targets by telling the make infra how to run tests remotely with remote-test-server.

This PR includes a revert of #102723 (cc @pcc), which disabled that test on all cross-compiled targets.

rust-highfive · 2022-10-18T07:54:00Z

r? @jyn514

(rust-highfive has picked a reviewer for you, use r? to override)

jyn514

Thanks! The code to support cross compiling seems reasonable, but the number of new ignores makes me worried you've missed a target and this will fail on the full test suite. I guess we can just try it and see though.

jyn514 · 2022-10-18T13:11:58Z

Why is this a FIXME? How would CUDA ever get support for libstd? (Is there some way we can say "ignore all targets without std"?)

That was present before #102723 (which I reverted), I don't have context on why those are fixmes.

The commit message adding this originally says 1fa48cf
nvtptx64-nvidia-cuda fails in rustc saying it can't find std. The rust
platforms support page says that std is supported on cuda so this is
surprising.
sounds like something is broken here but no need to fix it in your PR. cc @RDambrosio016 in case you know who maintains this target.

jyn514 · 2022-10-18T13:14:52Z

@bors rollup=iffy

jyn514 · 2022-10-18T15:00:34Z

@bors r+

bors · 2022-10-18T15:00:37Z

📌 Commit ca362edbdde20d7592643142ea2f00e9f65e2a9e has been approved by jyn514

It is now in the queue for this repository.

emilyalbini · 2022-10-24T07:58:57Z

Bors seemed to have lost the r+.

@bors r=jyn514

bors · 2022-10-24T07:58:59Z

📌 Commit ca362edbdde20d7592643142ea2f00e9f65e2a9e has been approved by jyn514

It is now in the queue for this repository.

bors · 2022-10-24T10:15:57Z

⌛ Testing commit ca362edbdde20d7592643142ea2f00e9f65e2a9e with merge eab05ae07aab4737b537dd0da052a7bcb2f21e99...

bors · 2022-10-24T10:54:33Z

💔 Test failed - checks-actions

emilyalbini · 2022-10-25T08:29:13Z

Installed the missing compiler in that builder, hopefully this is the only builder where it's missing 🤞

jyn514 · 2022-10-27T14:46:16Z

@bors r+ rollup=iffy

bors · 2022-10-27T14:46:18Z

📌 Commit cb096c148285f5f1146ec1a61cf0b297c78ec473 has been approved by jyn514

It is now in the queue for this repository.

bors · 2022-10-30T13:32:46Z

⌛ Testing commit cb096c148285f5f1146ec1a61cf0b297c78ec473 with merge fa8492c23ff5f8d57adf27c88dda77a1477623c8...

bors · 2022-10-30T14:13:36Z

💔 Test failed - checks-actions

emilyalbini · 2022-11-03T15:08:14Z

Android failed because of two problems:

When configuring the NDK we were not setting the cc and cxx bootstrap configs to point to the NDK's compilers. This didn't affect building code with Cargo, but resulted in the CC and CXX environment variables not being set correctly in run-make tests.
Android used the default value for TEST_DEVICE_ADDR and so didn't set the environment variable, breaking the detection logic I had in run-make.

I fixed both of the problems and successfully ran the run-make suite locally with src/ci/docker/run.sh.

bors · 2022-11-14T06:46:59Z

☔ The latest upstream changes (presumably #104188) made this pull request unmergeable. Please resolve the merge conflicts.

jyn514 · 2022-11-17T02:18:57Z

Sorry for the delay. r=me after a rebase.

This reverts commit 0567fec.

When running tests inside the Android emulator, bootstrap doesn't set the TEST_DEVICE_ADDR environment variable, as the default address (127.0.0.1:12345) is used. Instead, REMOTE_TEST_CLIENT is set all the times when remote testing is needed, and in no other cases. To ensure Android tests are executed in the emulator, change the check.

emilyalbini · 2022-11-17T08:52:29Z

@bors r=jyn514

bors · 2022-11-17T08:52:31Z

📌 Commit 6bfbd11 has been approved by jyn514

It is now in the queue for this repository.

bors · 2022-11-17T08:52:32Z

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

emilyalbini · 2022-11-17T08:57:15Z

@bors r=jyn514

bors · 2022-11-17T08:57:17Z

📌 Commit 00ec679 has been approved by jyn514

It is now in the queue for this repository.

bors · 2022-11-17T08:57:18Z

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

bors · 2022-11-18T06:54:40Z

⌛ Testing commit 00ec679 with merge 30117a1...

bors · 2022-11-18T10:06:21Z

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 30117a1 to master...

rust-timer · 2022-11-18T11:26:27Z

Finished benchmarking commit (30117a1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.7%	[2.5%, 5.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

rust-highfive assigned jyn514 Oct 18, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2022

jyn514 reviewed Oct 18, 2022
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2022

jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Oct 18, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 24, 2022

This comment has been minimized.
Sign in to view

rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Oct 25, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 30, 2022

This comment has been minimized.
Sign in to view

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Nov 3, 2022

jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2022

emilyalbini added 6 commits November 17, 2022 09:37

add support for running binaries with remote-test-client on run-make
b2c74ab

Revert "test: run-make: skip when cross-compiling"
ecaa342
This reverts commit 0567fec.

issue-36710 test can now run on cross-compiled targets
c80af32

install the target g++ in armhf-gnu
09340e3

set correct default value for cc and cxx on android
6d81602

emilyalbini force-pushed the pa-run-in-run-make branch from 6272ce4 to 6bfbd11Compare November 17, 2022 08:40

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 17, 2022

fmt
00ec679

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 18, 2022

bors merged commit 30117a1 into rust-lang:masterNov 18, 2022

rustbot added this to the 1.67.0 milestone Nov 18, 2022

emilyalbini deleted the pa-run-in-run-make branch November 18, 2022 10:16

Uh oh!

Uh oh!

Conversation

emilyalbini commented Oct 18, 2022

Uh oh!

rust-highfive commented Oct 18, 2022

Uh oh!

jyn514 left a comment

Choose a reason for hiding this comment

Uh oh!

jyn514Oct 18, 2022

Choose a reason for hiding this comment

Uh oh!

emilyalbiniOct 18, 2022

Choose a reason for hiding this comment

Uh oh!

jyn514Oct 18, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jyn514 commented Oct 18, 2022

Uh oh!

jyn514 commented Oct 18, 2022

Uh oh!

bors commented Oct 18, 2022

Uh oh!

emilyalbini commented Oct 24, 2022

Uh oh!

bors commented Oct 24, 2022

Uh oh!

bors commented Oct 24, 2022

Uh oh!

bors commented Oct 24, 2022

Uh oh!

This comment has been minimized.

emilyalbini commented Oct 25, 2022

Uh oh!

jyn514 commented Oct 27, 2022

Uh oh!

bors commented Oct 27, 2022

Uh oh!

bors commented Oct 30, 2022

Uh oh!

bors commented Oct 30, 2022

Uh oh!

This comment has been minimized.

emilyalbini commented Nov 3, 2022

Uh oh!

bors commented Nov 14, 2022

Uh oh!

jyn514 commented Nov 17, 2022

Uh oh!

emilyalbini commented Nov 17, 2022

Uh oh!

bors commented Nov 17, 2022

Uh oh!

bors commented Nov 17, 2022

Uh oh!

emilyalbini commented Nov 17, 2022

Uh oh!

bors commented Nov 17, 2022

Uh oh!

bors commented Nov 17, 2022

Uh oh!

bors commented Nov 18, 2022

Uh oh!

bors commented Nov 18, 2022

Uh oh!

rust-timer commented Nov 18, 2022

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone