rustdoc: Eliminate uses of `EarlyDocLinkResolver::all_traits` by petrochenkov · Pull Request #103192 · rust-lang/rust

petrochenkov · 2022-10-18T14:09:30Z

Another step to #94857.

rust-highfive · 2022-10-18T14:09:34Z

r? @notriddle

(rust-highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2022-10-18T14:10:10Z

@bors try @rust-timer queue

rust-timer · 2022-10-18T14:10:13Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-10-18T14:10:19Z

⌛ Trying commit c705f4b52448f40a922ff9fa787982d33baede5a with merge 1193205dc5163a9e46ee425d84782538e5d21fc7...

bors · 2022-10-18T16:38:32Z

☀️ Try build successful - checks-actions
Build commit: 1193205dc5163a9e46ee425d84782538e5d21fc7 (1193205dc5163a9e46ee425d84782538e5d21fc7)

rust-timer · 2022-10-18T16:38:34Z

Queued 1193205dc5163a9e46ee425d84782538e5d21fc7 with parent 21b2465, future comparison URL.

rust-timer · 2022-10-18T22:07:00Z

Finished benchmarking commit (1193205dc5163a9e46ee425d84782538e5d21fc7): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	19.1%	[0.7%, 50.8%]	17
Regressions ❌ (secondary)	18.5%	[0.6%, 59.0%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	19.1%	[0.7%, 50.8%]	17

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[2.2%, 4.0%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	18.8%	[2.8%, 44.2%]	16
Regressions ❌ (secondary)	17.9%	[2.7%, 50.8%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	18.8%	[2.8%, 44.2%]	16

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

petrochenkov · 2022-10-19T09:15:42Z

@bors try @rust-timer queue

rust-timer · 2022-10-19T09:15:44Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-10-19T09:23:44Z

⌛ Trying commit 1754745 with merge 6d369582bc7ad1b14d8af114b37b1ece37e8be86...

bors · 2022-10-19T11:20:55Z

☀️ Try build successful - checks-actions
Build commit: 6d369582bc7ad1b14d8af114b37b1ece37e8be86 (6d369582bc7ad1b14d8af114b37b1ece37e8be86)

rust-timer · 2022-10-19T11:20:57Z

Queued 6d369582bc7ad1b14d8af114b37b1ece37e8be86 with parent 84365ff, future comparison URL.

rust-timer · 2022-10-19T13:48:25Z

Finished benchmarking commit (6d369582bc7ad1b14d8af114b37b1ece37e8be86): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

the arithmetic mean of the percent change↩
number of relevant changes↩

petrochenkov · 2022-10-19T13:59:33Z

@bors rollup=maybe
@rustbot ready

jyn514 · 2022-10-19T15:42:52Z

@bors r+

bors · 2022-10-19T15:42:54Z

📌 Commit 1754745 has been approved by jyn514

It is now in the queue for this repository.

Rollup of 6 pull requests Successful merges: - rust-lang#101293 (Recover when unclosed char literal is parsed as a lifetime in some positions) - rust-lang#101908 (Suggest let for assignment, and some code refactor) - rust-lang#103192 (rustdoc: Eliminate uses of `EarlyDocLinkResolver::all_traits`) - rust-lang#103226 (Check `needs_infer` before `needs_drop` during HIR generator analysis) - rust-lang#103249 (resolve: Revert "Set effective visibilities for imports more precisely") - rust-lang#103305 (Move some tests to more reasonable places) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…omez rustdoc: Resolve doc links in external traits having local impls For external impls it was done in rust-lang#103192 right away, but the local impl case was forgotten. Fixesrust-lang#104145.

rust-highfive assigned notriddle Oct 18, 2022

rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 18, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 18, 2022

petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2022

rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 18, 2022

jyn514 reviewed Oct 19, 2022
View reviewed changes

Comment threadsrc/librustdoc/clean/blanket_impl.rs Outdated

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2022

rustdoc: Eliminate uses of EarlyDocLinkResolver::all_traits
1754745

petrochenkov force-pushed the noalltraits branch from c705f4b to 1754745Compare October 19, 2022 09:15

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 19, 2022

petrochenkov changed the title ~~rustdoc: Eliminate uses of all_traits~~rustdoc: Eliminate uses of EarlyDocLinkResolver::all_traitsOct 19, 2022

petrochenkov removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. perf-regression Performance regression. labels Oct 19, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 19, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2022

Dylan-DPC mentioned this pull request Oct 23, 2022
Rollup of 6 pull requests #103431
Merged

bors merged commit e426874 into rust-lang:masterOct 23, 2022

rustbot added this to the 1.66.0 milestone Oct 23, 2022

SarthakSingh31 mentioned this pull request Oct 25, 2022
thread 'rustc' panicked at 'no entry found for key', src/librustdoc/passes/collect_intra_doc_links.rs:781:16 #103463
Closed

petrochenkov mentioned this pull request Nov 13, 2022
rustdoc: Resolve doc links in external traits having local impls #104364
Merged

petrochenkov deleted the noalltraits branch February 22, 2025 18:30

Uh oh!

Uh oh!

Conversation

petrochenkov commented Oct 18, 2022

Uh oh!

rust-highfive commented Oct 18, 2022

Uh oh!

petrochenkov commented Oct 18, 2022

Uh oh!

rust-timer commented Oct 18, 2022

Uh oh!

bors commented Oct 18, 2022

Uh oh!

bors commented Oct 18, 2022

Uh oh!

rust-timer commented Oct 18, 2022

Uh oh!

rust-timer commented Oct 18, 2022

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Uh oh!

petrochenkov commented Oct 19, 2022

Uh oh!

rust-timer commented Oct 19, 2022

Uh oh!

bors commented Oct 19, 2022

Uh oh!

bors commented Oct 19, 2022

Uh oh!

rust-timer commented Oct 19, 2022

Uh oh!

rust-timer commented Oct 19, 2022

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

petrochenkov commented Oct 19, 2022

Uh oh!

jyn514 commented Oct 19, 2022

Uh oh!

bors commented Oct 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants