Skip to content

Fix item declaration highlighting - #103251

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:item-decl-highlighting
Oct 20, 2022
Merged

Fix item declaration highlighting#103251
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:item-decl-highlighting

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Fixes#103050.

As mentioned in the issue, #102924 introduced this regression. This PR partially reverts it and adds a regression test.

r? @notriddle

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 19, 2022
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2022
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez commented Oct 19, 2022

Copy link
Copy Markdown
MemberAuthor

Fixed the CI failure: it was because a new kind of item was added, shifting the elements in the sidebar by one.

@notriddle

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit b4e06a7 has been approved by notriddle

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 20, 2022
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#103197 (Stabilize proc_macro::Span::source_text)
- rust-lang#103251 (Fix item declaration highlighting)
- rust-lang#103262 (Adjusting test to needs-unwind, with linking issue)
- rust-lang#103268 (rustdoc: remove no-op CSS `nav.sub { font-size: 1rem }`)
- rust-lang#103272 (Remove extra spaces in docs)
- rust-lang#103276 (Erase regions before checking for `Default` in uninitialized binding error)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit e5514b9 into rust-lang:masterOct 20, 2022
@rustbotrustbot added this to the 1.66.0 milestone Oct 20, 2022
@GuillaumeGomez
GuillaumeGomez deleted the item-decl-highlighting branch October 20, 2022 16:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rustdoc .item-decl links are no longer highlighted

6 participants

@GuillaumeGomez@rustbot@rust-log-analyzer@notriddle@bors@rust-highfive