Fix `const_fn_trait_ref_impl`, add test for it by onestacked · Pull Request #104113 · rust-lang/rust

onestacked · 2022-11-07T16:44:26Z

#99943 broke #[feature(const_fn_trait_ref_impl)], this PR fixes this and adds a test for it.

rustbot · 2022-11-07T16:44:38Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

compiler-errors · 2022-11-07T17:53:42Z

Whoops, thanks.

@bors r+

bors · 2022-11-07T17:53:44Z

📌 Commit 0c9896b has been approved by compiler-errors

It is now in the queue for this repository.

compiler-errors · 2022-11-07T17:57:13Z

Actaully, one nit

@bors r-

onestacked · 2022-11-07T20:23:54Z

Whoops, thanks.

I should probably have had a test in my original PR

onestacked · 2022-11-07T20:30:26Z

+ };
+
+ // FIXME(const_cmp_tuple)
+ let test_one = test_fn(one);


Working on a PR for this, will fix this in the pr that is merged last

compiler-errors · 2022-11-07T20:31:14Z

@bors r+

bors · 2022-11-07T20:31:16Z

📌 Commit 87c190c has been approved by compiler-errors

It is now in the queue for this repository.

onestacked · 2022-11-07T20:37:07Z

could probably be rollup=always

compiler-errors · 2022-11-07T22:12:56Z

@bors rollup

…mpls, r=compiler-errors Fix `const_fn_trait_ref_impl`, add test for it rust-lang#99943 broke `#[feature(const_fn_trait_ref_impl)]`, this PR fixes this and adds a test for it. r? `@fee1-dead`

…mpls, r=compiler-errors Fix `const_fn_trait_ref_impl`, add test for it rust-lang#99943 broke `#[feature(const_fn_trait_ref_impl)]`, this PR fixes this and adds a test for it. r? ``@fee1-dead``

…mpls, r=compiler-errors Fix `const_fn_trait_ref_impl`, add test for it rust-lang#99943 broke `#[feature(const_fn_trait_ref_impl)]`, this PR fixes this and adds a test for it. r? ```@fee1-dead```

…llaumeGomez Rollup of 12 pull requests Successful merges: - rust-lang#103928 (Add 'ty_error_with_guaranteed' and 'const_error_with_guaranteed') - rust-lang#104027 (Place config.toml in current working directory if config not found) - rust-lang#104093 (disable btree size tests on Miri) - rust-lang#104097 (run alloc benchmarks in Miri and fix UB) - rust-lang#104104 (Add split-debuginfo print option) - rust-lang#104109 (rustdoc: Add mutable to the description) - rust-lang#104113 (Fix `const_fn_trait_ref_impl`, add test for it) - rust-lang#104114 (Fix invalid background-image file name) - rust-lang#104132 (fix: lint against lint functions) - rust-lang#104139 (Clarify licensing situation of MPSC and SPSC queue) - rust-lang#104147 (Remove an address comparison from the parser) - rust-lang#104165 (Add llvm-main to triagebot.toml) Failed merges: - rust-lang#104115 (Migrate crate-search element to CSS variables) r? `@ghost` `@rustbot` modify labels: rollup

…r=fee1-dead Const Compare for Tuples Makes the impls for Tuples of ~const `PartialEq` types also `PartialEq`, impls for Tuples of ~const `PartialOrd` types also `PartialOrd`, for Tuples of ~const `Ord` types also `Ord`. behind the `#![feature(const_cmp)]` gate. ~~Do not merge before rust-lang#104113 is merged because I want to use this feature to clean up the new test that I added there.~~ r? `@fee1-dead`

…r=fee1-dead Const Compare for Tuples Makes the impls for Tuples of ~const `PartialEq` types also `PartialEq`, impls for Tuples of ~const `PartialOrd` types also `PartialOrd`, for Tuples of ~const `Ord` types also `Ord`. behind the `#![feature(const_cmp)]` gate. ~~Do not merge before rust-lang#104113 is merged because I want to use this feature to clean up the new test that I added there.~~ r? ``@fee1-dead``

…r=fee1-dead Const Compare for Tuples Makes the impls for Tuples of ~const `PartialEq` types also `PartialEq`, impls for Tuples of ~const `PartialOrd` types also `PartialOrd`, for Tuples of ~const `Ord` types also `Ord`. behind the `#![feature(const_cmp)]` gate. ~~Do not merge before rust-lang#104113 is merged because I want to use this feature to clean up the new test that I added there.~~ r? ```@fee1-dead```

…r=fee1-dead Const Compare for Tuples Makes the impls for Tuples of ~const `PartialEq` types also `PartialEq`, impls for Tuples of ~const `PartialOrd` types also `PartialOrd`, for Tuples of ~const `Ord` types also `Ord`. behind the `#![feature(const_cmp)]` gate. ~~Do not merge before rust-lang#104113 is merged because I want to use this feature to clean up the new test that I added there.~~ r? ``@fee1-dead``

Fix const_fn_trait_ref_impl, add test for it
0c9896b

rustbot assigned fee1-dead Nov 7, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2022

onestacked mentioned this pull request Nov 7, 2022
Allow using Range as an Iterator in const contexts. #104100
Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2022

compiler-errors reviewed Nov 7, 2022
View reviewed changes

Comment threadsrc/test/ui/consts/fn_trait_refs.rs Outdated

Reworked const fn ref tests
87c190c

onestacked commented Nov 7, 2022
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 7, 2022

onestacked mentioned this pull request Nov 7, 2022
Const Compare for Tuples #104125
Merged

GuillaumeGomez mentioned this pull request Nov 8, 2022
Rollup of 8 pull requests #104143
Closed

onestacked mentioned this pull request Nov 8, 2022
Rebased const Iterator fee1-dead-contrib/rust#1
Closed

GuillaumeGomez mentioned this pull request Nov 8, 2022
Rollup of 11 pull requests #104151
Closed

GuillaumeGomez mentioned this pull request Nov 8, 2022
Rollup of 10 pull requests #104152
Closed

GuillaumeGomez mentioned this pull request Nov 8, 2022
Rollup of 12 pull requests #104168
Merged

bors merged commit 02db37a into rust-lang:masterNov 9, 2022

rustbot added this to the 1.67.0 milestone Nov 9, 2022

onestacked deleted the fix_const_fn_ref_impls branch November 9, 2022 03:16

Navigation Menu

Uh oh!

Uh oh!

Fix `const_fn_trait_ref_impl`, add test for it - #104113

Fix `const_fn_trait_ref_impl`, add test for it#104113
bors merged 2 commits into
rust-lang:masterfrom
ink-feather-org:fix_const_fn_ref_impls

onestacked commented Nov 7, 2022

Uh oh!

rustbot commented Nov 7, 2022

Uh oh!

compiler-errors commented Nov 7, 2022

Uh oh!

bors commented Nov 7, 2022

Uh oh!

compiler-errors commented Nov 7, 2022

Uh oh!

Uh oh!

onestacked commented Nov 7, 2022•
edited
Loading

Uh oh!

onestackedNov 7, 2022

Uh oh!

onestackedNov 7, 2022

Uh oh!

compiler-errors commented Nov 7, 2022

Uh oh!

bors commented Nov 7, 2022

Uh oh!

onestacked commented Nov 7, 2022•
edited
Loading

Uh oh!

compiler-errors commented Nov 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

onestacked commented Nov 7, 2022

Uh oh!

rustbot commented Nov 7, 2022

Uh oh!

compiler-errors commented Nov 7, 2022

Uh oh!

bors commented Nov 7, 2022

Uh oh!

compiler-errors commented Nov 7, 2022

Uh oh!

Uh oh!

onestacked commented Nov 7, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onestackedNov 7, 2022

Choose a reason for hiding this comment

Uh oh!

onestackedNov 7, 2022

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Nov 7, 2022

Uh oh!

bors commented Nov 7, 2022

Uh oh!

onestacked commented Nov 7, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compiler-errors commented Nov 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

onestacked commented Nov 7, 2022•
edited
Loading

onestacked commented Nov 7, 2022•
edited
Loading