rustdoc: use javascript to layout notable traits popups by notriddle · Pull Request #104129 · rust-lang/rust

notriddle · 2022-11-07T22:56:59Z

Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by

Before

After

rustbot · 2022-11-07T22:57:04Z

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2022-11-07T22:57:07Z

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

Fixesrust-lang#102576

GuillaumeGomez · 2022-11-08T16:23:14Z

It's similar to my approach in #91431. I personally like it. What do you think @Manishearth ?

Manishearth · 2022-11-08T16:54:40Z

Seems like a clean way to do this. Not elated about having more JS but I think this is as good a place to have it if any.

GuillaumeGomez · 2022-11-08T17:00:48Z

Let's just run a perf check beforehand but otherwise I think it's ready to go.

@bors try @rust-timer queue

bors · 2022-11-08T17:00:58Z

⌛ Trying commit a45151e with merge 9e5dcb830b5225cf66838466cf4a2db1058fa8d8...

bors · 2022-11-08T19:23:02Z

☀️ Try build successful - checks-actions
Build commit: 9e5dcb830b5225cf66838466cf4a2db1058fa8d8 (9e5dcb830b5225cf66838466cf4a2db1058fa8d8)

rust-timer · 2022-11-08T21:10:12Z

Finished benchmarking commit (9e5dcb830b5225cf66838466cf4a2db1058fa8d8): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.6%, 0.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.7%, 3.5%]	3
Improvements ✅ (primary)	-1.5%	[-2.1%, -1.0%]	2
Improvements ✅ (secondary)	-4.9%	[-4.9%, -4.9%]	1
All ❌✅ (primary)	-1.5%	[-2.1%, -1.0%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.2%	[-1.2%, -1.2%]	1
Improvements ✅ (secondary)	-11.7%	[-14.3%, -10.2%]	3
All ❌✅ (primary)	-1.2%	[-1.2%, -1.2%]	1

GuillaumeGomez · 2022-11-08T21:19:49Z

Seems fine so let's go!

@bors r+ rollup

…ble-trait, r=GuillaumeGomez rustdoc: use javascript to layout notable traits popups Fixesrust-lang#102576 Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by ## Before ![image](https://user-images.githubusercontent.com/1593513/200432713-23aa8d49-ba2b-469f-9eab-089e0c174039.png) ## After ![image](https://user-images.githubusercontent.com/1593513/200432735-edd5b53d-e99d-4fc5-9410-8a79e0efdc9d.png)

notriddle · 2022-11-11T13:58:36Z

@bors r-

failed in rollup

https://github.com/rust-lang-ci/rust/actions/runs/3444420445/jobs/5747010150

Manishearth · 2022-11-11T17:09:24Z

@bors r+

bors · 2022-11-11T17:09:26Z

📌 Commit 05824cd has been approved by Manishearth

It is now in the queue for this repository.

Manishearth · 2022-11-11T17:18:50Z

@bors rollup=iffy

…earth Rollup of 8 pull requests Successful merges: - rust-lang#95292 (Allow specialized const trait impls.) - rust-lang#100386 (Make `Sized` coinductive, again) - rust-lang#102215 (Implement the `+whole-archive` modifier for `wasm-ld`) - rust-lang#103468 (Fix unused lint and parser caring about spaces to won't produce invalid code) - rust-lang#103531 (Suggest calling the instance method of the same name when method not found) - rust-lang#103960 (piece of diagnostic migrate) - rust-lang#104051 (update Miri) - rust-lang#104129 (rustdoc: use javascript to layout notable traits popups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…it-v2, r=GuillaumeGomez rustdoc: use consistent "popover" styling for notable traits Follow-up to rust-lang#104129Fixesrust-lang#104313. Preview: https://notriddle.com/notriddle-rustdoc-demos/js-notable-trait-v2/std/iter/trait.Iterator.html#method.step_by ## Before ![image](https://user-images.githubusercontent.com/1593513/200710372-d2d992ce-0bdc-4437-9a2e-379a29df09cf.png) ![image](https://user-images.githubusercontent.com/1593513/200711266-e372b176-daa9-45f3-a022-738ef0a77d3c.png) ## After ![image](https://user-images.githubusercontent.com/1593513/200710601-09b3b717-116f-43c6-b14f-34a8b02b33c0.png) ![image](https://user-images.githubusercontent.com/1593513/200711288-3978cdc1-a6c2-47f6-9216-e22e3c1f5bdf.png)

…ble-trait, r=Manishearth rustdoc: use javascript to layout notable traits popups Fixesrust-lang#102576 Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by ## Before ![image](https://user-images.githubusercontent.com/1593513/200432713-23aa8d49-ba2b-469f-9eab-089e0c174039.png) ## After ![image](https://user-images.githubusercontent.com/1593513/200432735-edd5b53d-e99d-4fc5-9410-8a79e0efdc9d.png)

…earth Rollup of 8 pull requests Successful merges: - rust-lang#95292 (Allow specialized const trait impls.) - rust-lang#100386 (Make `Sized` coinductive, again) - rust-lang#102215 (Implement the `+whole-archive` modifier for `wasm-ld`) - rust-lang#103468 (Fix unused lint and parser caring about spaces to won't produce invalid code) - rust-lang#103531 (Suggest calling the instance method of the same name when method not found) - rust-lang#103960 (piece of diagnostic migrate) - rust-lang#104051 (update Miri) - rust-lang#104129 (rustdoc: use javascript to layout notable traits popups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

The old TODO comment stopped applying when rust-lang#104129 stopped nesting the notable traits popover within the header.

rustdoc: refactor notable_traits_decl to just act on the type directly
8e0cac1

rustbot assigned jsha Nov 7, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 7, 2022

notriddle force-pushed the notriddle/102576-js-notable-trait branch 6 times, most recently from 424ba55 to 92afac0Compare November 8, 2022 05:07

notriddle added 2 commits November 7, 2022 22:45

rustdoc: use javascript to layout notable traits popups
303653e
Fixesrust-lang#102576

rustdoc: fix font color inheritance from body, and test
a45151e

notriddle force-pushed the notriddle/102576-js-notable-trait branch from 92afac0 to a45151eCompare November 8, 2022 05:47

notriddle requested review from GuillaumeGomez and jsha November 8, 2022 06:34

GuillaumeGomez approved these changes Nov 8, 2022
View reviewed changes

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 8, 2022

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 8, 2022

Manishearth mentioned this pull request Nov 11, 2022
Rollup of 9 pull requests #104273
Closed

Dylan-DPC mentioned this pull request Nov 11, 2022
Rollup of 8 pull requests #104275
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 11, 2022

rustdoc: fix HTML validation failure by escaping data-ty
05824cd

notriddle force-pushed the notriddle/102576-js-notable-trait branch from b3edd70 to 05824cdCompare November 11, 2022 17:02

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 11, 2022

Manishearth mentioned this pull request Nov 11, 2022
Rollup of 8 pull requests #104293
Merged

bors merged commit b74d042 into rust-lang:masterNov 11, 2022

rustbot added this to the 1.67.0 milestone Nov 11, 2022

notriddle deleted the notriddle/102576-js-notable-trait branch November 11, 2022 23:33

notriddle mentioned this pull request Jun 1, 2023
rustdoc: add interaction delays for tooltip popovers #111892
Merged

notriddle added a commit to notriddle/rust that referenced this pull request Dec 1, 2023
rustdoc: make html checker a bit stricter
a3ef4ed
The old TODO comment stopped applying when rust-lang#104129 stopped nesting the notable traits popover within the header.

Uh oh!

Uh oh!

Conversation

notriddle commented Nov 7, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

Uh oh!

rustbot commented Nov 7, 2022

Uh oh!

rustbot commented Nov 7, 2022

Uh oh!

GuillaumeGomez commented Nov 8, 2022

Uh oh!

Manishearth commented Nov 8, 2022

Uh oh!

GuillaumeGomez commented Nov 8, 2022

Uh oh!

This comment has been minimized.

bors commented Nov 8, 2022

Uh oh!

bors commented Nov 8, 2022

Uh oh!

This comment has been minimized.

rust-timer commented Nov 8, 2022

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

GuillaumeGomez commented Nov 8, 2022

Uh oh!

notriddle commented Nov 11, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Manishearth commented Nov 11, 2022

Uh oh!

bors commented Nov 11, 2022

Uh oh!

Manishearth commented Nov 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

notriddle commented Nov 7, 2022•
edited
Loading

notriddle commented Nov 11, 2022•
edited
Loading