Rollup of 9 pull requests by Manishearth · Pull Request #104246 · rust-lang/rust

Manishearth · 2022-11-10T15:47:43Z

Successful merges:

Add loongarch64 abi support #101939 (Add loongarch64 abi support)
Use TraitEngine in more places, restrict visibility of FulfillmentCtxt constructor #103863 (Use TraitEngine in more places, restrict visibility of FulfillmentCtxt constructor)
Suggest is_some when we've found Option but expected bool #104036 (Suggest is_some when we've found Option but expected bool)
Make Hash, Hasher and BuildHasher#[const_trait] and make Sip const Hasher #104060 (Make Hash, Hasher and BuildHasher#[const_trait] and make Sip const Hasher)
Use aapcs for efiapi calling convention on arm #104077 (Use aapcs for efiapi calling convention on arm)
Tighten the 'introduce new binding' suggestion #104186 (Tighten the 'introduce new binding' suggestion)
EarlyBinder docs #104194 (EarlyBinder docs)
Don't ICE when encountering ConstKind::Error in RequiredConstsVisitor #104233 (Don't ICE when encountering ConstKind::Error in RequiredConstsVisitor)
Use const_error_with_guaranteed more #104235 (Use const_error_with_guaranteed more)

Failed merges:

Print "Checking/Building ..." message even when --dry-run is passed #104078 (Print "Checking/Building ..." message even when --dry-run is passed)
Migrate :target rules to use CSS variables #104169 (Migrate :target rules to use CSS variables)

r? @ghost
@rustbot modify labels: rollup

On arm, llvm treats the C calling convention as `aapcs` on soft-float targets and `aapcs-vfp` on hard-float targets [1]. UEFI specifies in the arm calling convention that floating point extensions aren't used [2], so always translate `efiapi` to `aapcs` on arm. [1]: rust-lang/compiler-builtins#116 (comment) [2]: https://uefi.org/specs/UEFI/2.10/02_Overview.html#detailed-calling-convention rust-lang#65815

… private

…i-obk Add loongarch64 abi support

…wesleywiser Use `TraitEngine` in more places, restrict visibility of `FulfillmentCtxt` constructor Most places that are constructing a `FulfillmentContext` should be constructing a `TraitEngine` generically, so later on if/when we're transitioning it'll be easier. Logical extension of rust-lang#99746

…rochenkov Suggest `is_some` when we've found `Option` but expected `bool` Thanks `@lunasorcery` for the suggestion.

…-dead Make `Hash`, `Hasher` and `BuildHasher` `#[const_trait]` and make `Sip` const `Hasher` This PR enables using Hashes in const context. r? ``@fee1-dead``

…r=nagisa Use aapcs for efiapi calling convention on arm On arm, [llvm treats the C calling convention as `aapcs` on soft-float targets and `aapcs-vfp` on hard-float targets](rust-lang/compiler-builtins#116 (comment)). UEFI specifies in the arm calling convention that [floating point extensions aren't used](https://uefi.org/specs/UEFI/2.10/02_Overview.html#detailed-calling-convention), so always translate `efiapi` to `aapcs` on arm. rust-lang#65815

…inding-issue, r=oli-obk Tighten the 'introduce new binding' suggestion Fixesrust-lang#104086

…ler-errors `EarlyBinder` docs

Don't ICE when encountering `ConstKind::Error` in `RequiredConstsVisitor` Fixesrust-lang#104209

…i-obk Use `const_error_with_guaranteed` more Better to pass down an ErrorGuaranteed rather than making a new one out of thin air, for some usages. Also for the ones where we *do* need to delay a bug, that delayed bug will have a more descriptive message.

Manishearth · 2022-11-10T15:47:57Z

@bors r+ p=5 rollup=never

bors · 2022-11-10T15:47:59Z

📌 Commit ea56e80 has been approved by Manishearth

It is now in the queue for this repository.

bors · 2022-11-10T16:23:03Z

⌛ Testing commit ea56e80 with merge a3c0a02...

bors · 2022-11-10T19:29:39Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing a3c0a02 to master...

rust-timer · 2022-11-10T19:32:13Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#104235	16d2fa404cba6240902a7e6a3398a8e1fa2bf117
#104233	ac3e054f6d6a72f588d93720c1c2914eeecc9595
#104194	734c2dcc016ba4a2e10ef127a34781b05459f192
#104186	2a8e011b523af777c8122816944a0a6080a7dd1c
#104077	6380928bf3aba6b0c2a63c11ad88d81cf3f4c77a
#104060	951a91a2723d5cbbe628ebf593651b58ce763781
#104036	b4e06becc81eecc4d4f576aef1765006a88a2030
#103863	1c141fa81bab538fb0a1bc072f99c00b772a8f4d
#101939	bc3bbac59ec1f88bc8a68d56d5abeab5ce3bdbc4

previous master: 01a6f30324

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-11-10T20:48:23Z

Finished benchmarking commit (a3c0a02): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.8%, -0.6%]	3
Improvements ✅ (secondary)	-0.5%	[-0.6%, -0.3%]	4
All ❌✅ (primary)	-0.7%	[-0.8%, -0.6%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.2%	[3.2%, 3.2%]	1
Regressions ❌ (secondary)	5.6%	[1.6%, 9.0%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.2%]	3
All ❌✅ (primary)	3.2%	[3.2%, 3.2%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.3%, 3.0%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

zhaixiaojuanand others added 27 commits September 17, 2022 18:00

Add loongarch64 abi support
c7961da

Made Hash and Hasher const_trait
1bcf9fa

Make BuildHasher const_trait
3ea4165

Made Sip const Hasher
5f9899b

Added const_hash tracking issue id
dc1f1a8

Removed unnecessary Trait bound
cebce1e

Test const Hash, fix nits
56e59bc

Fixrust-lang#104086, Tighten the 'introduce new binding' suggestion
952df48

fix tests and code cleanup
5689f9c

docs
4c197c0

add 'is_assign_rhs' to avoid weird suggesting 'let'
c69872b

Suggest is_some or let when encountering Option and bool type mismatch
38ada60

Use TraitEngine in more places, make FulfillmentCtxt constructor more…
ed17c6b
… private

bless a chalk test
27fddcf

Don't ICE when encountering ConstKind::Error in RequiredConstsVisitor
31157de

Use const_error_with_guaranteed more
0f89fb1

broken links go brrrrr
2566701

Rollup merge ofrust-lang#101939- zhaixiaojuan:loongarch64-abi, r=ol…
a7cd4f2
…i-obk Add loongarch64 abi support

Rollup merge ofrust-lang#104036- compiler-errors:option-sugg, r=pet…
529f714
…rochenkov Suggest `is_some` when we've found `Option` but expected `bool` Thanks `@lunasorcery` for the suggestion.

Rollup merge ofrust-lang#104060- ink-feather-org:const_hash, r=fee1…
150e0ec
…-dead Make `Hash`, `Hasher` and `BuildHasher` `#[const_trait]` and make `Sip` const `Hasher` This PR enables using Hashes in const context. r? ``@fee1-dead``

Rollup merge ofrust-lang#104186- chenyukang:yukang/fix-104086-let-b…
819c931
…inding-issue, r=oli-obk Tighten the 'introduce new binding' suggestion Fixesrust-lang#104086

Rollup merge ofrust-lang#104194- BoxyUwU:early_binder_docs, r=compi…
c6595ea
…ler-errors `EarlyBinder` docs

Rollup merge ofrust-lang#104233- compiler-errors:issue-104209, r=lcnr
77fde5d
Don't ICE when encountering `ConstKind::Error` in `RequiredConstsVisitor` Fixesrust-lang#104209

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 10, 2022

rustbot added the rollup A PR which is a rollup label Nov 10, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 10, 2022

bors merged commit a3c0a02 into rust-lang:masterNov 10, 2022

rustbot added this to the 1.67.0 milestone Nov 10, 2022

Manishearth deleted the rollup-9o3txc7 branch November 10, 2022 19:36

Navigation Menu

Uh oh!

Uh oh!

Rollup of 9 pull requests - #104246

Rollup of 9 pull requests#104246
bors merged 27 commits into
rust-lang:masterfrom
Manishearth:rollup-9o3txc7

Manishearth commented Nov 10, 2022

Uh oh!

Manishearth commented Nov 10, 2022

Uh oh!

bors commented Nov 10, 2022

Uh oh!

bors commented Nov 10, 2022

Uh oh!

bors commented Nov 10, 2022

Uh oh!

rust-timer commented Nov 10, 2022

Uh oh!

rust-timer commented Nov 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Uh oh!

Conversation

Manishearth commented Nov 10, 2022

Uh oh!

Manishearth commented Nov 10, 2022

Uh oh!

bors commented Nov 10, 2022

Uh oh!

bors commented Nov 10, 2022

Uh oh!

bors commented Nov 10, 2022

Uh oh!

rust-timer commented Nov 10, 2022

Uh oh!

rust-timer commented Nov 10, 2022

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants