Skip to content

Add a reference to ilog2 in leading_zeros integer docs - #104263

Merged
bors merged 3 commits into
rust-lang:masterfrom
albertlarsan68:add-ilog2-to-leading-zeroes-docs
Nov 12, 2022
Merged

Add a reference to ilog2 in leading_zeros integer docs#104263
bors merged 3 commits into
rust-lang:masterfrom
albertlarsan68:add-ilog2-to-leading-zeroes-docs

Conversation

@albertlarsan68

@albertlarsan68albertlarsan68 commented Nov 10, 2022

Copy link
Copy Markdown
Member

Fixes#104248

@rustbot

rustbot commented Nov 10, 2022

Copy link
Copy Markdown
Collaborator

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 10, 2022
@rustbot

rustbot commented Nov 10, 2022

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@albertlarsan68
albertlarsan68force-pushed the add-ilog2-to-leading-zeroes-docs branch 2 times, most recently from dce35ef to 38f2f1eCompareNovember 10, 2022 23:11
@albertlarsan68

albertlarsan68 commented Nov 10, 2022

Copy link
Copy Markdown
MemberAuthor

@rustbot label +A-docs

@rustbotrustbot added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Nov 10, 2022
@albertlarsan68
albertlarsan68force-pushed the add-ilog2-to-leading-zeroes-docs branch from 38f2f1e to d85b614CompareNovember 10, 2022 23:56
@rust-log-analyzer

This comment has been minimized.

Sign in to view
scottmcm
scottmcm reviewed Nov 11, 2022
View reviewed changes
Comment threadsrc/etc/pre-push.sh Outdated
scottmcm
scottmcm reviewed Nov 11, 2022
View reviewed changes
Comment threadlibrary/core/src/num/uint_macros.rs Outdated
scottmcm
scottmcm reviewed Nov 11, 2022
View reviewed changes
Comment threadlibrary/core/src/num/int_macros.rs Outdated
@scottmcmscottmcm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2022
@albertlarsan68

albertlarsan68 commented Nov 11, 2022

Copy link
Copy Markdown
MemberAuthor

CI passes, I hope the links are correct.

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 11, 2022
@scottmcm

scottmcm commented Nov 12, 2022

Copy link
Copy Markdown
Member

Thanks! If CI's happy hopefully that means that link's correct -- the macros definitely complicate things here.

@bors r+

@bors

bors commented Nov 12, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit a1909b7 has been approved by scottmcm

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2022
@albertlarsan68

albertlarsan68 commented Nov 12, 2022

Copy link
Copy Markdown
MemberAuthor

I took example on another doc comment in the same macros, which uses the "reference links" feature.

@albertlarsan68

albertlarsan68 commented Nov 12, 2022

Copy link
Copy Markdown
MemberAuthor

Can this PR be rolled up ?

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 12, 2022
@GuillaumeGomez
Rollup merge ofrust-lang#104263- albertlarsan68:add-ilog2-to-leadin…
338ca5c
…g-zeroes-docs, r=scottmcm
Add a reference to ilog2 in leading_zeros integer docs
Fixesrust-lang#104248
@GuillaumeGomezGuillaumeGomez mentioned this pull request Nov 12, 2022
Closed
@GuillaumeGomezGuillaumeGomez mentioned this pull request Nov 12, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 12, 2022
@bors
Auto merge ofrust-lang#104325- GuillaumeGomez:rollup-19bzwoa, r=Gui…
cd12888
…llaumeGomez
Rollup of 8 pull requests
Successful merges:
- rust-lang#104110 (prevent uninitialized access in black_box for zero-sized-types)
- rust-lang#104117 (Mark `trait_upcasting` feature no longer incomplete.)
- rust-lang#104144 (Suggest removing unnecessary `.` to use a floating point literal)
- rust-lang#104250 (Migrate no result page link color to CSS variables)
- rust-lang#104261 (More accurately report error when formal and expected signature types differ)
- rust-lang#104263 (Add a reference to ilog2 in leading_zeros integer docs)
- rust-lang#104308 (Remove the old `ValidAlign` name)
- rust-lang#104319 (Fix non clickable source link)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit cd4b3ac into rust-lang:masterNov 12, 2022
@rustbotrustbot added this to the 1.67.0 milestone Nov 12, 2022
@albertlarsan68
albertlarsan68 deleted the add-ilog2-to-leading-zeroes-docs branch November 12, 2022 20:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottmcmscottmcmscottmcm left review comments

Assignees

@scottmcmscottmcm

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.67.0

Development

Successfully merging this pull request may close these issues.

Mention ilog2 from leading_zeros docs

5 participants

@albertlarsan68@rustbot@rust-log-analyzer@scottmcm@bors