Skip to content

fix some typos in comments - #104349

Merged
bors merged 1 commit into
rust-lang:masterfrom
rustaceanclub:master
Nov 15, 2022
Merged

fix some typos in comments#104349
bors merged 1 commit into
rust-lang:masterfrom
rustaceanclub:master

Conversation

@cuishuang

@cuishuangcuishuang commented Nov 13, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@cuishuang
fix some typos in comments
442f848
Signed-off-by: cui fliter <imcusg@gmail.com>
@rustbot

rustbot commented Nov 13, 2022

Copy link
Copy Markdown
Collaborator

r? @estebank

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 13, 2022
@rustbot

rustbot commented Nov 13, 2022

Copy link
Copy Markdown
Collaborator

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

These commits modify compiler targets.
(See the Target Tier Policy.)

@oli-obk

oli-obk commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

@bors r+ rollup

Just a reminder: if this is done (semi-)automatically, please consider setting up the tooling in a way that everyone can run it with x.py so that we can some day run it in CI. Frequently opening such PRs may lead to them being closed without review if they would take too much effort to review

@bors

bors commented Nov 14, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 442f848 has been approved by oli-obk

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 14, 2022
@matthiaskrgr
Rollup merge ofrust-lang#104349- rustaceanclub:master, r=oli-obk
33163bb
fix some typos in comments
@matthiaskrgrmatthiaskrgr mentioned this pull request Nov 14, 2022
Closed
@matthiaskrgrmatthiaskrgr mentioned this pull request Nov 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2022
@bors
Auto merge ofrust-lang#104418- matthiaskrgr:rollup-y4i6xjc, r=matth…
101e182
…iaskrgr
Rollup of 11 pull requests
Successful merges:
- rust-lang#101967 (Move `unix_socket_abstract` feature API to `SocketAddrExt`.)
- rust-lang#102470 (Stabilize const char convert)
- rust-lang#104223 (Recover from function pointer types with generic parameter list)
- rust-lang#104229 (Don't print full paths in overlap errors)
- rust-lang#104294 (Don't ICE with inline const errors during MIR build)
- rust-lang#104332 (Fixed some `_i32` notation in `maybe_uninit`’s doc)
- rust-lang#104349 (fix some typos in comments)
- rust-lang#104350 (Fix x finding Python on Windows)
- rust-lang#104356 (interpret: make check_mplace public)
- rust-lang#104364 (rustdoc: Resolve doc links in external traits having local impls)
- rust-lang#104378 (Bump chalk to v0.87)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 5763fa7 into rust-lang:masterNov 15, 2022
@rustbotrustbot added this to the 1.67.0 milestone Nov 15, 2022
aDotInTheVoid added a commit to rust-lang/rustdoc-types that referenced this pull request Nov 21, 2022
@aDotInTheVoid
v0.19.0
1e078f7
rust-lang/rust#104499rust-lang/rust#104349rust-lang/rust#103664
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@estebankestebank

Labels

A-rustdoc-jsonArea: Rustdoc JSON backendS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.67.0

Development

Successfully merging this pull request may close these issues.

5 participants

@cuishuang@rustbot@oli-obk@bors@estebank