Uh oh!
There was an error while loading. Please reload this page.
Refactor must_use lint into two parts - #104359
Merged
Merged
Conversation
rustbot
commented
Nov 13, 2022
Collaborator
r? @fee1-dead (rustbot has picked a reviewer for you, use r? to override) |
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
jyn514
reviewed
Nov 14, 2022
Uh oh!
There was an error while loading. Please reload this page.
+ 1 on pluralization count from must_use lintNoratrieb
commented
Nov 17, 2022
MemberAuthor
I simplified the fix to really just do a |
This comment has been minimized.
This comment has been minimized.
fee1-dead
commented
Nov 19, 2022
Member
@rustbot author please fix CI |
Noratrieb
commented
Nov 19, 2022
MemberAuthor
It should work again now, but I still don't like the way some of these things are structured. I need to think about it a little more. |
Before, the lint did the checking for `must_use` and pretty printing the types in a special format in one pass, causing quite complex and untranslatable code. Now the collection and printing is split in two. That should also make it easier to translate or extract the type pretty printing in the future. Also fixes an integer overflow in the array length pluralization calculation.
fee1-dead
commented
Nov 20, 2022
Member
@bors r+ |
bors
commented
Nov 20, 2022
Collaborator
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Nov 22, 2022
Refactor must_use lint into two parts Before, the lint did the checking for `must_use` and pretty printing the types in a special format in one pass, causing quite complex and untranslatable code. Now the collection and printing is split in two. That should also make it easier to translate or extract the type pretty printing in the future. Also fixes an integer overflow in the array length pluralization calculation. fixesrust-lang#104352
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Nov 22, 2022
Refactor must_use lint into two parts Before, the lint did the checking for `must_use` and pretty printing the types in a special format in one pass, causing quite complex and untranslatable code. Now the collection and printing is split in two. That should also make it easier to translate or extract the type pretty printing in the future. Also fixes an integer overflow in the array length pluralization calculation. fixesrust-lang#104352
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Nov 23, 2022
Refactor must_use lint into two parts Before, the lint did the checking for `must_use` and pretty printing the types in a special format in one pass, causing quite complex and untranslatable code. Now the collection and printing is split in two. That should also make it easier to translate or extract the type pretty printing in the future. Also fixes an integer overflow in the array length pluralization calculation. fixesrust-lang#104352
This was referenced Nov 23, 2022
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 23, 2022
…earth Rollup of 6 pull requests Successful merges: - rust-lang#103488 (Allow opaque types in trait impl headers and rely on coherence to reject unsound cases) - rust-lang#104359 (Refactor must_use lint into two parts) - rust-lang#104612 (Lower return type outside async block creation) - rust-lang#104621 (Fix --extern library finding errors) - rust-lang#104647 (enable fuzzy_provenance_casts lint in liballoc and libstd) - rust-lang#104750 (Bump `fd-lock` in `bootstrap` again) Failed merges: - rust-lang#104732 (Refactor `ty::ClosureKind` related stuff) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the lint did the checking for
must_useand pretty printing the types in a special format in one pass, causing quite complex and untranslatable code.Now the collection and printing is split in two. That should also make it easier to translate or extract the type pretty printing in the future.
Also fixes an integer overflow in the array length pluralization
calculation.
fixes#104352