Uh oh!
There was an error while loading. Please reload this page.
Rollup of 11 pull requests - #104541
Closed
matthiaskrgr wants to merge 34 commits into
Closed
Conversation
Its name is now not accurate anymore, but we'll adjust that later
Backtraces can very significantly depending on environment and cause test suite failures spuriously. Ensuring a proper failure-status should be sufficient to keep a crash properly documented.
Clarify that the diagnostic can be retrieved with `steal_diagnostic`.
Before 7f6ce7d, light-theme where clauses had color `#4E4C4C` while the main color was `#000`. One of that commit's simplifications made it so that everything used the same black.
This commit takes advantage of the ability to set [flex-basis] to a specific length instead of setting it to `auto` and changing min-/max-width, and setting flex-grow/-shrink both to 0. [flex-basis]: https://developer.mozilla.org/en-US/docs/Web/CSS/flex-basis
… r=jyn514 Fix `x setup -h -v` should work r? `@jyn514` I have to convert profile to path and back in order to remove special-casing in bootstrap. I also check for `dry_run` so that `config.toml` and/ or `.git/hooks/pre-push` will not be created if `--dry-run` is specified. Please help me see if this is ok, thanks alot!
…impl, r=lcnr Don't remap early-bound regions for return-position `impl Trait` in trait originating from `impl` long title 😓 We don't want to remap early-bound regions that originate from the `impl`s themselves, since they have no corresponding region in the trait. Not sure if there's a better condition than checking if the EBR's def-id's parent is the impl -- maybe we should be checking if the region comes from the method or RPITIT... 🤷 r? types Fixesrust-lang#103850
…heme-choice, r=notriddle Simplify settings theme choice I removed the storage changes from rust-lang#98765 and only kept the UI changes. You can test it [here](https://rustdoc.crud.net/imperio/simplify-settings-theme-choice/foo/index.html). Discussion about this still in progress [on zulip](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/Last.20part.20of.20settings.20simplification). r? `@notriddle`
…mpiler-errors Fix ICE in in_operand for ty error Fixesrust-lang#104390 By the way, moving some test cases to proper directory for tidy bless.
…r=compiler-errors Convert predicates into Predicate in the Obligation constructor instead of having almost all callers do that. This reduces a bit of boilerplate, and also paves the way for my work towards rust-lang/compiler-team#531 (as it makes it easier to accept both goals and clauses where right now it only accepts predicates).
…backtraces, r=jackh726 Don't attempt to normalize compiler backtraces Backtraces can very significantly depending on environment and cause spurious test suite failures. Ensuring a proper failure-status should be sufficient to keep a crash properly documented. This caused a failure in Fuchsia's test suite CI due to an extra newline between "stack" and "error" appearing after normalization. cc `@jackh726` r? `@tmandry`
…er-errors Edit docs for `rustc_errors::Handler::stash_diagnostic` Clarify that the diagnostic can be retrieved with `steal_diagnostic`. r? `@compiler-errors`
…aumeGomez rustdoc: remove redundant font-color CSS on `.where` Before 7f6ce7d, light-theme where clauses had color `#4E4C4C` while the main color was `#000`. One of that commit's simplifications made it so that everything used the same black.
Check `dyn*` return type correctly In `check_fn`, if the declared return type is `dyn Trait`, then we check the return type separately to produce better diagnostics, because this is never valid -- however, when `dyn*` was introduced, this check was never adjusted to only account for *unsized* `dyn Trait` and not *sized* `dyn* Trait`. Fixesrust-lang#104501
…r=compiler-errors ICE fixing, remove is_tainted_by_errors since we have ty_error for delay bug Fixesrust-lang#104510
…ebar-width, r=GuillaumeGomez rustdoc: clean up sidebar width CSS This commit takes advantage of the ability to set [flex-basis] to a specific length instead of setting it to `auto` and changing min-/max-width, and setting flex-grow/-shrink both to 0. This PR should not cause any visual changes. preview: https://notriddle.com/notriddle-rustdoc-demos/flex-basis-sidebar-width/std/index.html [flex-basis]: https://developer.mozilla.org/en-US/docs/Web/CSS/flex-basis
matthiaskrgr
commented
Nov 17, 2022
MemberAuthor
@bors r+ rollup=never p=11 |
bors
commented
Nov 17, 2022
Collaborator
rust-log-analyzer
commented
Nov 17, 2022
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
x setup -h -vshould work #96584 (Fixx setup -h -vshould work)impl Traitin trait originating fromimpl#103852 (Don't remap early-bound regions for return-positionimpl Traitin trait originating fromimpl)rustc_errors::Handler::stash_diagnostic#104498 (Edit docs forrustc_errors::Handler::stash_diagnostic).where#104503 (rustdoc: remove redundant font-color CSS on.where)dyn*return type correctly #104508 (Checkdyn*return type correctly)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup