Skip to content

Add rustc_on_unimplemented to Sum and Product trait. - #105265

Merged
bors merged 1 commit into
rust-lang:masterfrom
aDotInTheVoid:sum-product-on-unimplemented
Dec 10, 2022
Merged

Add rustc_on_unimplemented to Sum and Product trait.#105265
bors merged 1 commit into
rust-lang:masterfrom
aDotInTheVoid:sum-product-on-unimplemented

Conversation

@aDotInTheVoid

@aDotInTheVoidaDotInTheVoid commented Dec 4, 2022

Copy link
Copy Markdown
Member

Helps with #105184, but I don't think it fully fixes it.

@rustbot

rustbot commented Dec 4, 2022

Copy link
Copy Markdown
Collaborator

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 4, 2022
@rustbot

rustbot commented Dec 4, 2022

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

aDotInTheVoid
aDotInTheVoid commented Dec 4, 2022
View reviewed changes
Comment threadlibrary/core/src/iter/traits/accum.rs Outdated
compiler-errors
compiler-errors reviewed Dec 4, 2022
View reviewed changes
Comment threadlibrary/core/src/iter/traits/accum.rs Outdated
@estebank

estebank commented Dec 7, 2022

Copy link
Copy Markdown
Contributor

r? @estebank

@rustbotrustbot assigned estebank and unassigned davidtwcoDec 7, 2022
@aDotInTheVoid
aDotInTheVoidforce-pushed the sum-product-on-unimplemented branch from 1e49429 to f13eec1CompareDecember 8, 2022 13:33
@estebank

estebank commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

You'll have to rebase on a recent master, there is going to be a merge conflict on the first note in the new tests.

@aDotInTheVoid
aDotInTheVoidforce-pushed the sum-product-on-unimplemented branch from f13eec1 to 5626df9CompareDecember 8, 2022 23:08
@aDotInTheVoid

aDotInTheVoid commented Dec 8, 2022

Copy link
Copy Markdown
MemberAuthor

Rebased onto latest master. I wounder why RLA didn't triger.

@estebank

estebank commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

You created a new test whose output changed since you created it. It wouldn't have been caught until CI caught it during rollup. I just knew about it because I caused the change :)

@estebank

estebank commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 5626df9 has been approved by estebank

It is now in the queue for this repository.

@bors

bors commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Dec 9, 2022
@Dylan-DPC
Rollup merge ofrust-lang#105265- aDotInTheVoid:sum-product-on-unimp…
bd92c94
…lemented, r=estebank
Add `rustc_on_unimplemented` to `Sum` and `Product` trait.
Helps with rust-lang#105184, but I don't think it fully fixes it.
@Dylan-DPCDylan-DPC mentioned this pull request Dec 9, 2022
Closed
@matthiaskrgrmatthiaskrgr mentioned this pull request Dec 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2022
@bors
Auto merge ofrust-lang#105512- matthiaskrgr:rollup-i74avrf, r=matth…
a000811
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#102406 (Make `missing_copy_implementations` more cautious)
- rust-lang#105265 (Add `rustc_on_unimplemented` to `Sum` and `Product` trait.)
- rust-lang#105385 (Skip test on s390x as LLD does not support the platform)
- rust-lang#105453 (Make `VecDeque::from_iter` O(1) from `vec(_deque)::IntoIter`)
- rust-lang#105468 (Mangle "main" as "__main_void" on wasm32-wasi)
- rust-lang#105480 (rustdoc: remove no-op mobile CSS `#sidebar-toggle { text-align }`)
- rust-lang#105489 (Fix typo in apple_base.rs)
- rust-lang#105504 (rustdoc: make stability badge CSS more consistent)
- rust-lang#105506 (Tweak `rustc_must_implement_one_of` diagnostic output)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 856027a into rust-lang:masterDec 10, 2022
@rustbotrustbot added this to the 1.68.0 milestone Dec 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebankestebankestebank approved these changes
+1 more reviewer
@compiler-errorscompiler-errorscompiler-errors left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@estebankestebank

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

6 participants

@aDotInTheVoid@rustbot@estebank@bors@compiler-errors@davidtwco