Uh oh!
There was an error while loading. Please reload this page.
Support eager subdiagnostics again - #105806
Merged
Merged
Conversation
rustbot
commented
Dec 17, 2022
Collaborator
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wesleywiser (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
commented
Dec 17, 2022
Collaborator
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
davidtwco
approved these changes
Jan 7, 2023
davidtwco
left a comment
Member
There was a problem hiding this comment.
Apologies for the delay in reviewing, r=me after fixing the comment.
Uh oh!
There was an error while loading. Please reload this page.
davidtwco
commented
Jan 9, 2023
Member
@bors r+ |
bors
commented
Jan 9, 2023
Collaborator
JohnTitor pushed a commit
to JohnTitor/rust
that referenced
this pull request
Jan 10, 2023
Support eager subdiagnostics again See rust-lang#104941 (comment) I'm not sure how to add a test for this. But I did pick some of the diagnostic structs in the mentioned PR and it works with them.
Member
bors
commented
Jan 11, 2023
Collaborator
Noratrieb added a commit
to Noratrieb/rust
that referenced
this pull request
Jan 12, 2023
Support eager subdiagnostics again See rust-lang#104941 (comment) I'm not sure how to add a test for this. But I did pick some of the diagnostic structs in the mentioned PR and it works with them.
This was referenced Jan 12, 2023
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#105806 (Support eager subdiagnostics again) - rust-lang#106322 (Handle inference variables in `CollectAllMismatches` correctly) - rust-lang#106579 (Suggest making private tuple struct field public) - rust-lang#106714 (remove unreachable error code `E0490`) - rust-lang#106751 (Fix rendering 'const' in header for intrinsics) - rust-lang#106761 (Add `WaffleLapkin` to compiler reviewers) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #104941 (comment)
I'm not sure how to add a test for this. But I did pick some of the diagnostic structs in the mentioned PR and it works with them.