Uh oh!
There was an error while loading. Please reload this page.
Move check_region_obligations_and_report_errors to TypeErrCtxt - #106164
Merged
Conversation
rustbot
commented
Dec 26, 2022
Collaborator
r? @Nilstrieb (rustbot has picked a reviewer for you, use r? to override) |
Noratrieb
commented
Dec 27, 2022
Member
This looks reasonable to me but I'm not familiar with this code, so I'll r? types for a second look over it |
bors
commented
Dec 28, 2022
Collaborator
☔ The latest upstream changes (presumably #106129) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errorsforce-pushed
the
check-region-tweak
branch
from
January 3, 2023 23:58
8f5248e to
c104ee9Compareoli-obk
commented
Jan 9, 2023
Contributor
@bors r+ rollup |
bors
commented
Jan 9, 2023
Collaborator
JohnTitor pushed a commit
to JohnTitor/rust
that referenced
this pull request
Jan 9, 2023
…, r=oli-obk Move `check_region_obligations_and_report_errors` to `TypeErrCtxt` Makes sense for this function to live with its sibling `resolve_regions_and_report_errors`, around which it's basically just a wrapper.
JohnTitor pushed a commit
to JohnTitor/rust
that referenced
this pull request
Jan 9, 2023
…, r=oli-obk Move `check_region_obligations_and_report_errors` to `TypeErrCtxt` Makes sense for this function to live with its sibling `resolve_regions_and_report_errors`, around which it's basically just a wrapper.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2023
…fee1-dead Rollup of 10 pull requests Successful merges: - rust-lang#105292 (Change a commit_if_ok call to probe) - rust-lang#105655 (Remove invalid case for mutable borrow suggestion) - rust-lang#106047 (Fix ui constant tests for big-endian platforms) - rust-lang#106061 (Enable Shadow Call Stack for Fuchsia on AArch64) - rust-lang#106164 (Move `check_region_obligations_and_report_errors` to `TypeErrCtxt`) - rust-lang#106291 (Fix incorrect suggestion for extra `&` in pattern) - rust-lang#106389 (Simplify some canonical type alias names) - rust-lang#106468 (Use FxIndexSet when updating obligation causes in `adjust_fulfillment_errors_for_expr_obligation`) - rust-lang#106549 (Use fmt named parameters in rustc_borrowck) - rust-lang#106614 (error-code docs improvements (No. 2)) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sense for this function to live with its sibling
resolve_regions_and_report_errors, around which it's basically just a wrapper.