Rollup of 7 pull requests by matthiaskrgr · Pull Request #106472 · rust-lang/rust

matthiaskrgr · 2023-01-04T22:39:53Z

Successful merges:

rustdoc: allow popover child links to work #106391 (rustdoc: allow popover child links to work)
Fix a few clippy lints in libtest #106398 (Fix a few clippy lints in libtest)
Fix link generation for local primitive types in rustdoc JSON output #106412 (Fix link generation for local primitive types in rustdoc JSON output)
rustdoc: fix buggy JS check for absolute URL #106437 (rustdoc: fix buggy JS check for absolute URL)
Merge borrowck permission checks #106451 (Merge borrowck permission checks)
Move tests #106460 (Move tests)
docs: fix broken link "search bar" #106461 (docs: fix broken link "search bar")

Failed merges:

r? @ghost
@rustbot modify labels: rollup

No need to prevent default click behavior on a <div>, it will also disable all child click behavior.

- Remove unnecessary references and dereferences - Use `.contains` instead of `a <= x && x <= b` - Use `mem::take` instead of `mem::replace` where possible

The old code did the wrong thing when faced with a crate named "http".

Merge `check_access_permission` and `check_if_reassignment_to_immutable_state`. The goal of this commit is twofold: First, we simplify the codebase by removing duplicate logic. Second, we avoid duplicate reporting of illegal reassignment errors by reusing the exiting de-duplicating logic of access_place.

…GuillaumeGomez rustdoc: allow popover child links to work No need to prevent default click behavior on a `<div>`, it will also disable all child click behavior. Closesrust-lang#106390

Fix a few clippy lints in libtest - Remove unnecessary references and dereferences - Use `.contains` instead of `a <= x && x <= b` - Use `mem::take` instead of `mem::replace` where possible cc rust-lang#106394 :)

…ive-rustdoc-json, r=aDotInTheVoid Fix link generation for local primitive types in rustdoc JSON output Fixesrust-lang#104064. As mentioned in the issue, I'm not super happy about this fix which is more a hack rather than a sound-proof solution. However I couldn't find a better way to fix it. r? `@aDotInTheVoid`

…illaumeGomez rustdoc: fix buggy JS check for absolute URL The old code did the wrong thing when faced with a crate named "http".

…stebank Merge borrowck permission checks Merge `check_access_permission` and `check_if_reassignment_to_immutable_state`. The goal of this commit is twofold: * simplify the codebase by removing duplicate logic. * avoid duplicate reporting of illegal reassignment errors by reusing the exiting de-duplicating logic of access_place.

…rrors Move tests r? `@petrochenkov`

…tate-focus, r=GuillaumeGomez docs: fix broken link "search bar" Regression introduced by rust-lang#84150

matthiaskrgr · 2023-01-04T22:40:16Z

@bors r+ rollup=never p=7

bors · 2023-01-04T22:40:18Z

📌 Commit 06b2df4 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-01-05T01:06:09Z

⌛ Testing commit 06b2df4 with merge d26242d...

bors · 2023-01-05T03:59:24Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing d26242d to master...

rust-timer · 2023-01-05T04:01:33Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#106461	27ab1107e68e7bcd0b23ca27e91961dfe2c9f867
#106460	25b95d3cbc54fb1bacb4d5e35e68379c5de2be62
#106451	e78290ae79a90c2a78cc2200b50e006d1953e49c
#106437	8cccbd634a39c0ab5f365f87b9411a2ec3ae7990
#106412	aa468e323051d76d6293477aeed5c8c6dcf4092c
#106398	baec9b6f07cda2cc9cc8c73ed6e0873e7f314be6
#106391	faf71f6f041745fa7c04d8561d04b37241ec5cbd

previous master: d9e317a176

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-01-05T05:19:11Z

Finished benchmarking commit (d26242d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.6%	[-1.8%, -1.4%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.8%	[-0.8%, -0.8%]	1

ardisluand others added 18 commits January 2, 2023 17:26

rustdoc: allow popover child links to work
6c254ed
No need to prevent default click behavior on a <div>, it will also disable all child click behavior.

Fix link generation for local primitive types in rustdoc JSON output
59eee74

Add regression test forrust-lang#104064
f69fee4

Fix a few clippy lints in libtest
3534e0a
- Remove unnecessary references and dereferences - Use `.contains` instead of `a <= x && x <= b` - Use `mem::take` instead of `mem::replace` where possible

rustdoc: fix buggy JS check for absolute URL
49111ec
The old code did the wrong thing when faced with a crate named "http".

Add test case to click popover child link
2399df2

Add hardcoded wait time for external navigation to load
9792c9a

Move tests
7ffcedf

docs: fix broken link "search bar"
854082c

Remove unused match pattern for primitive types
c9ebd73

Rollup merge ofrust-lang#106391- ardislu:fix-popover-child-link, r=…
b41d81c
…GuillaumeGomez rustdoc: allow popover child links to work No need to prevent default click behavior on a `<div>`, it will also disable all child click behavior. Closesrust-lang#106390

Rollup merge ofrust-lang#106398- jyn514:fix-clippy, r=thomcc
5eb9698
Fix a few clippy lints in libtest - Remove unnecessary references and dereferences - Use `.contains` instead of `a <= x && x <= b` - Use `mem::take` instead of `mem::replace` where possible cc rust-lang#106394 :)

Rollup merge ofrust-lang#106437- notriddle:notriddle/http-url, r=Gu…
836321e
…illaumeGomez rustdoc: fix buggy JS check for absolute URL The old code did the wrong thing when faced with a crate named "http".

Rollup merge ofrust-lang#106460- c410-f3r:moar-errors, r=compiler-e…
3df7cd9
…rrors Move tests r? `@petrochenkov`

Rollup merge ofrust-lang#106461- notriddle:notriddle/window-searchs…
06b2df4
…tate-focus, r=GuillaumeGomez docs: fix broken link "search bar" Regression introduced by rust-lang#84150

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 5, 2023

bors merged commit d26242d into rust-lang:masterJan 5, 2023

rustbot added this to the 1.68.0 milestone Jan 5, 2023

This was referenced Jan 5, 2023
First attempt at removing DropAndReplace #104488
Closed
Modify primary span label for E0308 #106399
Merged
Move src/test to the root #106458
Merged

matthiaskrgr deleted the rollup-4w4v50e branch March 16, 2024 18:18

Navigation Menu

Uh oh!

Uh oh!

Rollup of 7 pull requests - #106472

Rollup of 7 pull requests#106472
bors merged 18 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-4w4v50e

matthiaskrgr commented Jan 4, 2023

Uh oh!

matthiaskrgr commented Jan 4, 2023

Uh oh!

bors commented Jan 4, 2023

Uh oh!

bors commented Jan 5, 2023

Uh oh!

bors commented Jan 5, 2023

Uh oh!

rust-timer commented Jan 5, 2023

Uh oh!

rust-timer commented Jan 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Uh oh!

Conversation

matthiaskrgr commented Jan 4, 2023

Uh oh!

matthiaskrgr commented Jan 4, 2023

Uh oh!

bors commented Jan 4, 2023

Uh oh!

bors commented Jan 5, 2023

Uh oh!

bors commented Jan 5, 2023

Uh oh!

rust-timer commented Jan 5, 2023

Uh oh!

rust-timer commented Jan 5, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants