Uh oh!
There was an error while loading. Please reload this page.
Only load one CSS theme by default - #106915
Merged
Merged
Conversation
rustbot
commented
Jan 15, 2023
Collaborator
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
commented
Jan 15, 2023
Collaborator
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
notriddleforce-pushed
the
notriddle/load-only-one-theme
branch
from
January 15, 2023 23:47
026251c to
9268e25Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
approved these changes
Jan 16, 2023
GuillaumeGomez
commented
Jan 16, 2023
Member
Looks good to me but I'll let @jsha have the final word on this. |
bors
commented
Jan 30, 2023
Collaborator
☔ The latest upstream changes (presumably #107472) made this pull request unmergeable. Please resolve the merge conflicts. |
notriddleforce-pushed
the
notriddle/load-only-one-theme
branch
from
February 17, 2023 21:56
2ddc164 to
3f46624CompareUh oh!
There was an error while loading. Please reload this page.
GuillaumeGomez
approved these changes
Feb 18, 2023
GuillaumeGomez
commented
Feb 18, 2023
Member
Looks good to me, thanks! |
bors
commented
Mar 7, 2023
Collaborator
☔ The latest upstream changes (presumably #108863) made this pull request unmergeable. Please resolve the merge conflicts. |
jsha
commented
Mar 8, 2023
Contributor
Looks great to me. r=me with the merge conflicts resolved. |
To avoid generating a FOUC at startup, this commit uses `document.write` to load the stylesheet initially. Co-Authored-By: Guillaume Gomez <guillaume1.gomez@gmail.com>
Use NEAR check to allow one pixel difference between scroll positions.
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
notriddleforce-pushed
the
notriddle/load-only-one-theme
branch
from
March 8, 2023 19:49
c9bb98c to
255fdb3Comparenotriddle
commented
Mar 8, 2023
ContributorAuthor
@bors r=GuillaumeGomez,jsha rollup |
bors
commented
Mar 8, 2023
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 10, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#106915 (Only load one CSS theme by default) - rust-lang#108294 (Place binder correctly for arbitrary trait bound suggestion) - rust-lang#108778 (x fmt: Don't print all modified files if there's more than 10) - rust-lang#108854 (feat/refactor: improve errors in case of ident with number at start) - rust-lang#108870 (Fix invalid inlining of reexport of reexport of private item) - rust-lang#108917 (Consider target_family as pal) - rust-lang#108922 (Add auto notification for changes to stable mir) - rust-lang#108929 (Fix typo in span_map.rs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tweaked version of #103971 that uses
document.writeto create the stylesheet link at startup, avoiding a FOUC during page navigation. It also rebases the PR, making it work with the new hashed filenames.Fixes#82614
Preview: http://notriddle.com/notriddle-rustdoc-demos/load-only-one-theme-v2/std/index.html