Uh oh!
There was an error while loading. Please reload this page.
rustdoc: Fix glob import inlining - #106952
Conversation
Filter away names that are not actually imported by the glob, e.g. because they are shadowed by something else
rustbot
commented
Jan 16, 2023
r? @notriddle (rustbot has picked a reviewer for you, use r? to override) |
GuillaumeGomez
commented
Jan 16, 2023
Looks good to me, thanks! r=me once CI pass |
notriddle
commented
Jan 16, 2023
Looks like a reasonable fix. It might have a perf impact, so: @bors r=notriddle,GuillaumeGomez rollup=never |
bors
commented
Jan 16, 2023
bors
commented
Jan 18, 2023
bors
commented
Jan 18, 2023
☀️ Test successful - checks-actions |
rust-timer
commented
Jan 18, 2023
Finished benchmarking commit (aaa9bb9): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Filter away names that are not actually imported by the glob, e.g. because they are shadowed by something else.
Fixes the issue found in #94857 (comment).